| Message ID | 1569479710-32314-1-git-send-email-hayashi.kunihiko@socionext.com |
|---|---|
| State | Accepted |
| Commit | fd4a8093ec0bd37d450587d50f3e10f0af57cc47 |
| Headers | show |
| Series | [net] net: socionext: ave: Avoid using netdev_err() before calling register_netdev() | expand |
From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Date: Thu, 26 Sep 2019 15:35:10 +0900 > Until calling register_netdev(), ndev->dev_name isn't specified, and > netdev_err() displays "(unnamed net_device)". > > ave 65000000.ethernet (unnamed net_device) (uninitialized): invalid phy-mode setting > ave: probe of 65000000.ethernet failed with error -22 > > This replaces netdev_err() with dev_err() before calling register_netdev(). > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> Applied.
diff --git a/drivers/net/ethernet/socionext/sni_ave.c b/drivers/net/ethernet/socionext/sni_ave.c index 10d0c3e..f20f6c4 100644 --- a/drivers/net/ethernet/socionext/sni_ave.c +++ b/drivers/net/ethernet/socionext/sni_ave.c @@ -1662,19 +1662,19 @@ static int ave_probe(struct platform_device *pdev) "socionext,syscon-phy-mode", 1, 0, &args); if (ret) { - netdev_err(ndev, "can't get syscon-phy-mode property\n"); + dev_err(dev, "can't get syscon-phy-mode property\n"); goto out_free_netdev; } priv->regmap = syscon_node_to_regmap(args.np); of_node_put(args.np); if (IS_ERR(priv->regmap)) { - netdev_err(ndev, "can't map syscon-phy-mode\n"); + dev_err(dev, "can't map syscon-phy-mode\n"); ret = PTR_ERR(priv->regmap); goto out_free_netdev; } ret = priv->data->get_pinmode(priv, phy_mode, args.args[0]); if (ret) { - netdev_err(ndev, "invalid phy-mode setting\n"); + dev_err(dev, "invalid phy-mode setting\n"); goto out_free_netdev; }
Until calling register_netdev(), ndev->dev_name isn't specified, and netdev_err() displays "(unnamed net_device)". ave 65000000.ethernet (unnamed net_device) (uninitialized): invalid phy-mode setting ave: probe of 65000000.ethernet failed with error -22 This replaces netdev_err() with dev_err() before calling register_netdev(). Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> --- drivers/net/ethernet/socionext/sni_ave.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) -- 2.7.4