From patchwork Thu Sep 26 18:38:03 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 174513 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp2438551ill; Thu, 26 Sep 2019 11:39:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpGbUO5hKu9vjMdpWG/w7kiHv5sdUZBNn646wqNDd5yFt1vg5qdIzgr8PzdC7yu8UGvyfA X-Received: by 2002:a6b:8d06:: with SMTP id p6mr4392642iod.219.1569523196618; Thu, 26 Sep 2019 11:39:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1569523196; cv=none; d=google.com; s=arc-20160816; b=pKpaLmAivUOWyYIR3In+v8sSPnBMV1raLR1B9YJQ69CaQ2LjI82Cbnf8xZ97xxBgYh ITPf+YPtMHF+E54Z6L85KSjkiwsSeTb3L5qOExm36vU7XjOdNREPd7zG0OM+gcYb9gOy k6f0xRqjIRU9wmG1SngxmzgmQQhuSGvqtHgtDZCZtTFmp8mAwKf7jCtgvwAS7RL5fDkb LQfwBMXaW9uhHFW0bn4Psp4HI9ekDjim6N2lv8LVj9OQpLLUIuihC269trYFN3ML/WZa 8P0j7BLJu4Hc7GlOP+yxL3+8warqREdJo1hr8LGXlkVNENKXrvVXbpMhQ5zxOLgGxGUS DuWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=pb6ppKmzDdc45ve1UlSMO6QmUZRgbMTrJlrL++C+nSw=; b=B5hogp/F+W+Q4qkIeZkBTwN0N+hcl97Wk3I369ZrEJYX5wh1RHtrVni9n5NN20N7Sm GFc67b11HyXfeWBG7qinFmbTjh9D3wfpCDn5J8/wZz7d2FrrkC23x9JDsVAjfqn2Seog lpXAZDIiUk2h2nsz5J4oP7T6G42YKuhr06FwfUCGAdcPMjmY+53579zxa6lfnSoGAAs0 HVeuc91wcxjZpEtwujfT8ZvKoJR2627AtYF0pQ995aWlAQfQpkFxNuvnKWmuCOEcOmlM oyBdEYKX2XOLyx4eYX8CShcVQcW4TJosZzPHiySQHDZ0/7Oew/qdpwbo1URu5GK+L/zI ZmSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id w29si175494ilk.119.2019.09.26.11.39.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Sep 2019 11:39:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDYet-0002Sr-W4; Thu, 26 Sep 2019 18:38:31 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1iDYes-0002Rw-QZ for xen-devel@lists.xenproject.org; Thu, 26 Sep 2019 18:38:30 +0000 X-Inumbo-ID: cf323ec6-e08c-11e9-97fb-bc764e2007e4 Received: from foss.arm.com (unknown [217.140.110.172]) by localhost (Halon) with ESMTP id cf323ec6-e08c-11e9-97fb-bc764e2007e4; Thu, 26 Sep 2019 18:38:18 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 705BA1596; Thu, 26 Sep 2019 11:38:18 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A36583F67D; Thu, 26 Sep 2019 11:38:17 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 26 Sep 2019 19:38:03 +0100 Message-Id: <20190926183808.11630-6-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190926183808.11630-1-julien.grall@arm.com> References: <20190926183808.11630-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH RFC for-4.13 05/10] xen/arm: alternative: Remove unused parameter for alternative_if_not_cap X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk , andrii.anisov@gmail.com MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The macro alternative_if_not_cap is taking two parameters. The second parameter is never used and it is hard to see how this can be used correctly as it is only protecting the alternative section magic. Signed-off-by: Julien Grall Reviewed-by: Volodymyr Babchuk Acked-by: Stefano Stabellini --- xen/include/asm-arm/alternative.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/xen/include/asm-arm/alternative.h b/xen/include/asm-arm/alternative.h index dedb6dd001..2830a6da2d 100644 --- a/xen/include/asm-arm/alternative.h +++ b/xen/include/asm-arm/alternative.h @@ -116,13 +116,11 @@ int apply_alternatives(const struct alt_instr *start, const struct alt_instr *en * The code that follows this macro will be assembled and linked as * normal. There are no restrictions on this code. */ -.macro alternative_if_not cap, enable = 1 - .if \enable +.macro alternative_if_not cap .pushsection .altinstructions, "a" altinstruction_entry 661f, 663f, \cap, 662f-661f, 664f-663f .popsection 661: - .endif .endm /*