media: dt-bindings: media: Fixup Allwinner A10 CSI binding

Message ID b47ec7088aa4b07458519ab151de92df552a9302.1570101510.git.amit.kucheria@linaro.org
State New
Headers show
Series
  • media: dt-bindings: media: Fixup Allwinner A10 CSI binding
Related show

Commit Message

Amit Kucheria Oct. 3, 2019, 11:22 a.m.
This new binding fails dt_binding_check due to a typo. Fix it up.

linux.git/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename
linux.git/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed
make[2]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
linux.git/Makefile:1284: recipe for target 'dt_binding_check' failed
make[1]: *** [dt_binding_check] Error 2

Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding")
Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

---
 .../devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Amit Kucheria Oct. 5, 2019, 10:45 a.m. | #1
On Thu, Oct 3, 2019 at 5:22 PM Maxime Ripard <mripard@kernel.org> wrote:
>

> Hi,

>

> On Thu, Oct 03, 2019 at 04:52:24PM +0530, Amit Kucheria wrote:

> > This new binding fails dt_binding_check due to a typo. Fix it up.

> >

> > linux.git/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename

> > linux.git/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed

> > make[2]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1

> > make[2]: *** Waiting for unfinished jobs....

> > linux.git/Makefile:1284: recipe for target 'dt_binding_check' failed

> > make[1]: *** [dt_binding_check] Error 2

> >

> > Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding")

> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

>

> Thanks for your patch.

>

> It has already been submitted though:

> https://lore.kernel.org/linux-arm-kernel/1568808060-17516-1-git-send-email-pragnesh.patel@sifive.com/

>

> I'm not sure why it hasn't been applied yet though :/


Perhaps a Fixes tag will allow more attention to it?
Maxime Ripard Oct. 7, 2019, 10:05 a.m. | #2
On Sat, Oct 05, 2019 at 04:15:57PM +0530, Amit Kucheria wrote:
> On Thu, Oct 3, 2019 at 5:22 PM Maxime Ripard <mripard@kernel.org> wrote:

> >

> > Hi,

> >

> > On Thu, Oct 03, 2019 at 04:52:24PM +0530, Amit Kucheria wrote:

> > > This new binding fails dt_binding_check due to a typo. Fix it up.

> > >

> > > linux.git/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename

> > > linux.git/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed

> > > make[2]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1

> > > make[2]: *** Waiting for unfinished jobs....

> > > linux.git/Makefile:1284: recipe for target 'dt_binding_check' failed

> > > make[1]: *** [dt_binding_check] Error 2

> > >

> > > Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding")

> > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

> >

> > Thanks for your patch.

> >

> > It has already been submitted though:

> > https://lore.kernel.org/linux-arm-kernel/1568808060-17516-1-git-send-email-pragnesh.patel@sifive.com/

> >

> > I'm not sure why it hasn't been applied yet though :/

>

> Perhaps a Fixes tag will allow more attention to it?


I've added a fixes tag and merged it through the sunxi tree.

Sorry for the time it took, and thanks for sending that fix!
Maxime
Amit Kucheria Oct. 7, 2019, 10:15 a.m. | #3
On Mon, Oct 7, 2019 at 3:35 PM Maxime Ripard <mripard@kernel.org> wrote:
>

> On Sat, Oct 05, 2019 at 04:15:57PM +0530, Amit Kucheria wrote:

> > On Thu, Oct 3, 2019 at 5:22 PM Maxime Ripard <mripard@kernel.org> wrote:

> > >

> > > Hi,

> > >

> > > On Thu, Oct 03, 2019 at 04:52:24PM +0530, Amit Kucheria wrote:

> > > > This new binding fails dt_binding_check due to a typo. Fix it up.

> > > >

> > > > linux.git/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename

> > > > linux.git/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed

> > > > make[2]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1

> > > > make[2]: *** Waiting for unfinished jobs....

> > > > linux.git/Makefile:1284: recipe for target 'dt_binding_check' failed

> > > > make[1]: *** [dt_binding_check] Error 2

> > > >

> > > > Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding")

> > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

> > >

> > > Thanks for your patch.

> > >

> > > It has already been submitted though:

> > > https://lore.kernel.org/linux-arm-kernel/1568808060-17516-1-git-send-email-pragnesh.patel@sifive.com/

> > >

> > > I'm not sure why it hasn't been applied yet though :/

> >

> > Perhaps a Fixes tag will allow more attention to it?

>

> I've added a fixes tag and merged it through the sunxi tree.

>

> Sorry for the time it took, and thanks for sending that fix!


Will it get merged for -rc2?
Rob Herring Oct. 22, 2019, 4:17 p.m. | #4
On Mon, Oct 7, 2019 at 5:48 AM Maxime Ripard <mripard@kernel.org> wrote:
>

> On Mon, Oct 07, 2019 at 03:45:29PM +0530, Amit Kucheria wrote:

> > On Mon, Oct 7, 2019 at 3:35 PM Maxime Ripard <mripard@kernel.org> wrote:

> > >

> > > On Sat, Oct 05, 2019 at 04:15:57PM +0530, Amit Kucheria wrote:

> > > > On Thu, Oct 3, 2019 at 5:22 PM Maxime Ripard <mripard@kernel.org> wrote:

> > > > >

> > > > > Hi,

> > > > >

> > > > > On Thu, Oct 03, 2019 at 04:52:24PM +0530, Amit Kucheria wrote:

> > > > > > This new binding fails dt_binding_check due to a typo. Fix it up.

> > > > > >

> > > > > > linux.git/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml: $id: path/filename 'arm/allwinner,sun4i-a10-csi.yaml' doesn't match actual filename

> > > > > > linux.git/Documentation/devicetree/bindings/Makefile:12: recipe for target 'Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts' failed

> > > > > > make[2]: *** [Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.example.dts] Error 1

> > > > > > make[2]: *** Waiting for unfinished jobs....

> > > > > > linux.git/Makefile:1284: recipe for target 'dt_binding_check' failed

> > > > > > make[1]: *** [dt_binding_check] Error 2

> > > > > >

> > > > > > Fixes: c5e8f4ccd7750 ("media: dt-bindings: media: Add Allwinner A10 CSI binding")

> > > > > > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

> > > > >

> > > > > Thanks for your patch.

> > > > >

> > > > > It has already been submitted though:

> > > > > https://lore.kernel.org/linux-arm-kernel/1568808060-17516-1-git-send-email-pragnesh.patel@sifive.com/

> > > > >

> > > > > I'm not sure why it hasn't been applied yet though :/

> > > >

> > > > Perhaps a Fixes tag will allow more attention to it?

> > >

> > > I've added a fixes tag and merged it through the sunxi tree.

> > >

> > > Sorry for the time it took, and thanks for sending that fix!

> >

> > Will it get merged for -rc2?

>

> -rc2 was released yesterday, so we're a bit late for that, but it's

>  going to be in next tomorrow.


Is this going to Linus anytime soon? It is affecting anyone submitting
bindings against current -rc's.

Rob

Patch

diff --git a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml
index 27f38eed389e4..5dd1cf490cd9d 100644
--- a/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml
+++ b/Documentation/devicetree/bindings/media/allwinner,sun4i-a10-csi.yaml
@@ -1,7 +1,7 @@ 
 # SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
 %YAML 1.2
 ---
-$id: http://devicetree.org/schemas/arm/allwinner,sun4i-a10-csi.yaml#
+$id: http://devicetree.org/schemas/media/allwinner,sun4i-a10-csi.yaml#
 $schema: http://devicetree.org/meta-schemas/core.yaml#
 
 title: Allwinner A10 CMOS Sensor Interface (CSI) Device Tree Bindings