From patchwork Tue Oct 8 21:12:14 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 175576 Delivered-To: patch@linaro.org Received: by 2002:a92:7e96:0:0:0:0:0 with SMTP id q22csp6230868ill; Tue, 8 Oct 2019 14:12:44 -0700 (PDT) X-Google-Smtp-Source: APXvYqysE0iLAOu7LJ7H0WFn2PM47yY6oJeWXo8Snr94paoProXVYr8Rsq43vNs5tQxKY7zQdFCm X-Received: by 2002:a17:906:1f57:: with SMTP id d23mr31372669ejk.103.1570569164157; Tue, 08 Oct 2019 14:12:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1570569164; cv=none; d=google.com; s=arc-20160816; b=q1SoUM3eOE6EVgHnbJd6rr/GhJC5W/qItxfgXyPagI9B6b43NqTwixQnr0l+RrSvOF l4Wpf7P4CCAYJSjvKa3PBqPVr5vDHWenVYnAVh4CRedcEvoeMcjBVI6oGfm4qCYqQUA9 n40h2sM7fB/tKDXHHEQ28PqkGC0+YYvtdBAS+z4Z0FEL1akRTZEySSmNwmpJnT60TcNs XRcBQiKdtmxUuGoi5PBT9QRP0VR8wJlbwKelpBFvdGs/gYuWLNTn4iejIKpTCdbMsQpK xsn7A2oVARwt/ikQvjAnLXfLf8beFVnT7g39J8DfhUOJL+gWF+4dtrET/CEH0r7CPAfP Ei/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=kvfGr4DKZy5j3QNPzfpyjUtZMohBZzTnp1s3rclQedI=; b=0cMgg/E/SAurZt2nHtXGPoY3QYdRC37p9e2xIaeTir4p/NnHPNyWcK7i5ve5MJ6Zsj Zu5lQmz4dUrpM73sM/32RkMKJQeJVIxVRjzSQR5KMAyKzFKfJXVPT8toGU/Z1zp/ScDv 1KdAAwqwjnASA10bPe6xqdh1zrgpCGL1FSGzBG88wMUGKWKtKjesl0hUOfmD4x55u2wD W9oIUygzoYfBy7Niu2QIy8vK5cqHDJJ+PqttLpz9ew+xRN+1NCHWHfZxaOksPcPI0fIv 7pjYC3qlbeHscASKYt5jhQW2PCPBAQdbieSgRZXOUbcogholyM6RDJVHrtjWXsEZfX/S 5MIw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id p14si158421eda.411.2019.10.08.14.12.43; Tue, 08 Oct 2019 14:12:44 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 26BD41C119; Tue, 8 Oct 2019 23:12:42 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id 304731C124; Tue, 8 Oct 2019 23:12:40 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 856CA28; Tue, 8 Oct 2019 14:12:39 -0700 (PDT) Received: from qc2400f-1.austin.arm.com (qc2400f-1.austin.arm.com [10.118.12.34]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7467B3F68E; Tue, 8 Oct 2019 14:12:39 -0700 (PDT) From: Honnappa Nagarahalli To: honnappa.nagarahalli@arm.com, david.marchand@redhat.com, konstantin.ananyev@intel.com Cc: dev@dpdk.org, ruifeng.wang@arm.com, stable@dpdk.org, nd@arm.com Date: Tue, 8 Oct 2019 16:12:14 -0500 Message-Id: <20191008211220.31586-2-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191008211220.31586-1-honnappa.nagarahalli@arm.com> References: <20191008211220.31586-1-honnappa.nagarahalli@arm.com> Subject: [dpdk-dev] [PATCH v2 1/7] doc/rcu: fix typos X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix typos. Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism") Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Reviewed-by: Gavin Hu --- doc/guides/prog_guide/rcu_lib.rst | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.17.1 diff --git a/doc/guides/prog_guide/rcu_lib.rst b/doc/guides/prog_guide/rcu_lib.rst index 8fe5b1f73..c019dfca8 100644 --- a/doc/guides/prog_guide/rcu_lib.rst +++ b/doc/guides/prog_guide/rcu_lib.rst @@ -37,8 +37,8 @@ What is Quiescent State ----------------------- Quiescent State can be defined as "any point in the thread execution where the -thread does not hold a reference to shared memory". It is up to the application -to determine its quiescent state. +thread does not hold a reference to shared memory". It is the responsibility of +the application to determine its quiescent state. Let us consider the following diagram: @@ -76,7 +76,7 @@ Factors affecting the RCU mechanism It is important to make sure that this library keeps the overhead of identifying the end of grace period and subsequent freeing of memory, -to a minimum. The following explains how grace period and critical +to a minimum. The following paras explain how grace period and critical section affect this overhead. The writer has to poll the readers to identify the end of grace period. @@ -91,14 +91,14 @@ critical sections smaller requires additional CPU cycles (due to additional reporting) in the readers. Hence, we need the characteristics of a small grace period and large critical -section. This library addresses this by allowing the writer to do -other work without having to block until the readers report their quiescent -state. +section. This library addresses these characteristics by allowing the writer +to do other work without having to block until the readers report their +quiescent state. RCU in DPDK ----------- -For DPDK applications, the start and end of a ``while(1)`` loop (where no +For DPDK applications, the beginning and end of a ``while(1)`` loop (where no references to shared data structures are kept) act as perfect quiescent states. This will combine all the shared data structure accesses into a single, large critical section which helps keep the overhead on the @@ -106,11 +106,11 @@ reader side to a minimum. DPDK supports a pipeline model of packet processing and service cores. In these use cases, a given data structure may not be used by all the -workers in the application. The writer does not have to wait for all -the workers to report their quiescent state. To provide the required -flexibility, this library has a concept of a QS variable. The application -can create one QS variable per data structure to help it track the -end of grace period for each data structure. This helps keep the grace +workers in the application. The writer has to wait only for the workers that +use the data structure to report their quiescent state. To provide the required +flexibility, this library has a concept of a QS variable. If required, the +application can create one QS variable per data structure to help it track the +end of grace period for each data structure. This helps keep the length of grace period to a minimum. How to use this library