| Message ID | 51B053A6.5070605@linaro.org |
|---|---|
| State | Accepted |
| Headers | show |
On 6 June 2013 10:17, Will Newton <will.newton@linaro.org> wrote: > > ARM uses @ as a comment character, but % seems to be usable by all > existing ifunc enabled architectures. > > gdb/testsuite/ChangeLog: > > 2013-06-05 Will Newton <will.newton@linaro.org> > > * gdb.base/gnu-ifunc-lib.c: Use %function instead of @function > in asm syntax to allow building on ARM. > --- > gdb/testsuite/gdb.base/gnu-ifunc-lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ping? -- Will Newton Toolchain Working Group, Linaro
On 6 June 2013 10:17, Will Newton <will.newton@linaro.org> wrote: > > ARM uses @ as a comment character, but % seems to be usable by all > existing ifunc enabled architectures. > > gdb/testsuite/ChangeLog: > > 2013-06-05 Will Newton <will.newton@linaro.org> > > * gdb.base/gnu-ifunc-lib.c: Use %function instead of @function > in asm syntax to allow building on ARM. > --- > gdb/testsuite/gdb.base/gnu-ifunc-lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Ping? -- Will Newton Toolchain Working Group, Linaro
On 21 June 2013 11:58, Will Newton <will.newton@linaro.org> wrote: > On 6 June 2013 10:17, Will Newton <will.newton@linaro.org> wrote: >> >> ARM uses @ as a comment character, but % seems to be usable by all >> existing ifunc enabled architectures. >> >> gdb/testsuite/ChangeLog: >> >> 2013-06-05 Will Newton <will.newton@linaro.org> >> >> * gdb.base/gnu-ifunc-lib.c: Use %function instead of @function >> in asm syntax to allow building on ARM. >> --- >> gdb/testsuite/gdb.base/gnu-ifunc-lib.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Ping? Ping? -- Will Newton Toolchain Working Group, Linaro
On 06/06/2013 10:17 AM, Will Newton wrote: > > ARM uses @ as a comment character, but % seems to be usable by all > existing ifunc enabled architectures. > > gdb/testsuite/ChangeLog: > > 2013-06-05 Will Newton <will.newton@linaro.org> > > * gdb.base/gnu-ifunc-lib.c: Use %function instead of @function > in asm syntax to allow building on ARM. OK.
diff --git a/gdb/testsuite/gdb.base/gnu-ifunc-lib.c b/gdb/testsuite/gdb.base/gnu-ifunc-lib.c index 803ac93..a3fe061 100644 --- a/gdb/testsuite/gdb.base/gnu-ifunc-lib.c +++ b/gdb/testsuite/gdb.base/gnu-ifunc-lib.c @@ -21,7 +21,7 @@ extern int final (int arg); typedef int (*final_t) (int arg); -asm (".type gnu_ifunc, @gnu_indirect_function"); +asm (".type gnu_ifunc, %gnu_indirect_function"); final_t gnu_ifunc (void)