mfd: twl: endian fixups in i2c write and read wrappers.

Message ID 20191013093015.1395332-1-jic23@kernel.org
State New
Headers show
Series
  • mfd: twl: endian fixups in i2c write and read wrappers.
Related show

Commit Message

Jonathan Cameron Oct. 13, 2019, 9:30 a.m.
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>


Use a local variable to ensure correct endian types for
intermediate results.

Identified by sparse when building the IIO driver.

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Cc: Lee Jones <lee.jones@linaro.org>
---
 include/linux/mfd/twl.h | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

-- 
2.23.0

Comments

Lee Jones Oct. 16, 2019, 9:58 a.m. | #1
On Sun, 13 Oct 2019, jic23@kernel.org wrote:

> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> 

> Use a local variable to ensure correct endian types for

> intermediate results.

> 

> Identified by sparse when building the IIO driver.

> 

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> Cc: Lee Jones <lee.jones@linaro.org>

> ---

>  include/linux/mfd/twl.h | 12 ++++++++----

>  1 file changed, 8 insertions(+), 4 deletions(-)


Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

Patch

diff --git a/include/linux/mfd/twl.h b/include/linux/mfd/twl.h
index 44aff52a5002..089e8942223a 100644
--- a/include/linux/mfd/twl.h
+++ b/include/linux/mfd/twl.h
@@ -181,14 +181,18 @@  static inline int twl_i2c_read_u8(u8 mod_no, u8 *val, u8 reg) {
 }
 
 static inline int twl_i2c_write_u16(u8 mod_no, u16 val, u8 reg) {
-	val = cpu_to_le16(val);
-	return twl_i2c_write(mod_no, (u8*) &val, reg, 2);
+	__le16 value;
+
+	value = cpu_to_le16(val);
+	return twl_i2c_write(mod_no, (u8 *) &value, reg, 2);
 }
 
 static inline int twl_i2c_read_u16(u8 mod_no, u16 *val, u8 reg) {
 	int ret;
-	ret = twl_i2c_read(mod_no, (u8*) val, reg, 2);
-	*val = le16_to_cpu(*val);
+	__le16 value;
+
+	ret = twl_i2c_read(mod_no, (u8 *) &value, reg, 2);
+	*val = le16_to_cpu(value);
 	return ret;
 }