diff mbox series

[v5,01/55] trace: expand mem_info:size_shift to 4 bits

Message ID 20191014104948.4291-2-alex.bennee@linaro.org
State Superseded
Headers show
Series Support for TCG plugins | expand

Commit Message

Alex Bennée Oct. 14, 2019, 10:48 a.m. UTC 
From: "Emilio G. Cota" <cota@braap.org>


This will allow us to trace 32k-long memory accesses (although our
maximum is something like 256 bytes at the moment).

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Emilio G. Cota <cota@braap.org>

[AJB: expanded to 3->4 bits]
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


---
v5
  - return the tweaks to mem-internal.h
---
 trace-events         | 2 +-
 trace/mem-internal.h | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

-- 
2.20.1

Comments

Richard Henderson Oct. 14, 2019, 2:35 p.m. UTC | #1 
On 10/14/19 3:48 AM, Alex Bennée wrote:
> From: "Emilio G. Cota" <cota@braap.org>

> 

> This will allow us to trace 32k-long memory accesses (although our

> maximum is something like 256 bytes at the moment).

> 

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Emilio G. Cota <cota@braap.org>

> [AJB: expanded to 3->4 bits]

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> 

> ---

> v5

>   - return the tweaks to mem-internal.h

> ---

>  trace-events         | 2 +-

>  trace/mem-internal.h | 8 ++++----

>  2 files changed, 5 insertions(+), 5 deletions(-)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>



r~
diff mbox series

Patch

diff --git a/trace-events b/trace-events
index 20821ba545..22133dfd3f 100644
--- a/trace-events
+++ b/trace-events
@@ -149,7 +149,7 @@  vcpu guest_cpu_reset(void)
 # Access information can be parsed as:
 #
 # struct mem_info {
-#     uint8_t size_shift : 2; /* interpreted as "1 << size_shift" bytes */
+#     uint8_t size_shift : 4; /* interpreted as "1 << size_shift" bytes */
 #     bool    sign_extend: 1; /* sign-extended */
 #     uint8_t endianness : 1; /* 0: little, 1: big */
 #     bool    store      : 1; /* wheter it's a store operation */
diff --git a/trace/mem-internal.h b/trace/mem-internal.h
index 3444fbc596..1a010c1b27 100644
--- a/trace/mem-internal.h
+++ b/trace/mem-internal.h
@@ -10,10 +10,10 @@ 
 #ifndef TRACE__MEM_INTERNAL_H
 #define TRACE__MEM_INTERNAL_H
 
-#define TRACE_MEM_SZ_SHIFT_MASK 0x7 /* size shift mask */
-#define TRACE_MEM_SE (1ULL << 3)    /* sign extended (y/n) */
-#define TRACE_MEM_BE (1ULL << 4)    /* big endian (y/n) */
-#define TRACE_MEM_ST (1ULL << 5)    /* store (y/n) */
+#define TRACE_MEM_SZ_SHIFT_MASK 0xf /* size shift mask */
+#define TRACE_MEM_SE (1ULL << 4)    /* sign extended (y/n) */
+#define TRACE_MEM_BE (1ULL << 5)    /* big endian (y/n) */
+#define TRACE_MEM_ST (1ULL << 6)    /* store (y/n) */
 
 static inline uint8_t trace_mem_build_info(
     int size_shift, bool sign_extend, MemOp endianness, bool store)