| Message ID | 20191112064058.13275-4-joel@jms.id.au |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm/aspeed: Watchdog and SDRAM fixes | expand |
On 12/11/2019 07:40, Joel Stanley wrote: > Users benefit from knowing which watchdog timer has expired. The address > of the watchdog's registers unambiguously indicates which has expired, > so log that. > > Signed-off-by: Joel Stanley <joel@jms.id.au> The format below should be using HWADDR_PRIx. No need to resend. I will fix it. Reviewed-by: Cédric Le Goater <clg@kaod.org> C. > --- > hw/watchdog/wdt_aspeed.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c > index 145be6f99ce2..5697ed83325a 100644 > --- a/hw/watchdog/wdt_aspeed.c > +++ b/hw/watchdog/wdt_aspeed.c > @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev) > return; > } > > - qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n"); > + qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %08lx expired.\n", > + s->iomem.addr); > watchdog_perform_action(); > timer_del(s->timer); > } >
diff --git a/hw/watchdog/wdt_aspeed.c b/hw/watchdog/wdt_aspeed.c index 145be6f99ce2..5697ed83325a 100644 --- a/hw/watchdog/wdt_aspeed.c +++ b/hw/watchdog/wdt_aspeed.c @@ -219,7 +219,8 @@ static void aspeed_wdt_timer_expired(void *dev) return; } - qemu_log_mask(CPU_LOG_RESET, "Watchdog timer expired.\n"); + qemu_log_mask(CPU_LOG_RESET, "Watchdog timer %08lx expired.\n", + s->iomem.addr); watchdog_perform_action(); timer_del(s->timer); }
Users benefit from knowing which watchdog timer has expired. The address of the watchdog's registers unambiguously indicates which has expired, so log that. Signed-off-by: Joel Stanley <joel@jms.id.au> --- hw/watchdog/wdt_aspeed.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.24.0