From patchwork Wed Nov 20 15:45:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 179864 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp2276420ilf; Wed, 20 Nov 2019 07:45:53 -0800 (PST) X-Google-Smtp-Source: APXvYqy/IjKa3o982m4gZ7/1Q35eO+YoKrG6oOTXGnmT5MdxUGkngcqd7MkipM3X/1DTrSM9hq9A X-Received: by 2002:a5d:4b08:: with SMTP id v8mr3973108wrq.338.1574264753403; Wed, 20 Nov 2019 07:45:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574264753; cv=none; d=google.com; s=arc-20160816; b=L6kMdlvxxLIF//AXZsWt9fT58azLOauxH2HkgJ3ev+sBFzmfSC1gFwrlfM6ch/w2k3 hIlUyLq6ws3fjNiSARG4eZuZzBJ7MEzsLa3I5HzaY7mhHppOMMJXma+JivyOaPyvPULl 0itR7qjifvMfrGVoDs0QfphFsDl4x+ayeYwAljrh0wD6j3AANl3Vvey4NIugKSMYSYgF eqB5wO36TW3hIHoD5f1HZ5OrQTY70agxjTPVKPUBRhV9/n+jvRsr3R7dYCuIk0pzZld4 KavMP1QnZd2jY0o7dIeBPcaU7Wq9ffjJtWOvNWIczG7Ql4+VsN6DKR+vZYSXVoYc35q1 jdLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=bSlvEnhnK1QbvCSKvaCG0JDjT521YdJTB3I7+y6Gtgs35LKelTM1uRfDQsYyPAE48n pvlyPczSZ0/3A6bL5NhbiMhxOQpjk8dmrsQa56bZ7462j7CnsO5pEEMj2o5EWhJd1pIH iVliYV5VqeI+SlCD2nywi1YcG6YVMUhXYSUsNn3wjd7wogQofWauLqP3miV71q9dwhVp eVbVRDMp78p21B74tYJsycwwEQTUEcfiEafQ+hKd1Lt41Pa0ovHur/scjbfwVXWB+MUz g/C3rM/In+EteWwkQaDQKWBYxT84ch951SNYNF0mH9fi9y0ADyJgXW9kQCuy9v7rRP8s sKCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3AnSLk8; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q19si17972067eda.112.2019.11.20.07.45.53; Wed, 20 Nov 2019 07:45:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=E3AnSLk8; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730153AbfKTPpw (ORCPT + 10 others); Wed, 20 Nov 2019 10:45:52 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45688 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732455AbfKTPpv (ORCPT ); Wed, 20 Nov 2019 10:45:51 -0500 Received: by mail-pg1-f196.google.com with SMTP id k1so12187137pgg.12 for ; Wed, 20 Nov 2019 07:45:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=E3AnSLk8a93bsgWxr4fcB/GPFvJ4Rxo5soxyRn5bqg6l49xuRK6YcbzlIUUW+u31d/ JA22kRY/pMbbK6pIyxFgfeLHI+IcM3+2nwmI0qvXJDZabbmDuqUiVLRhLr/SlgQh51oV UsRDODil4tFnA/SKcLzQnQ+fH8TLmKtJQuaXjNyammLFz8sJfJUN/4NBihEftSt/l1LP x+sqw0txJaK5+awwGSe60/jM8OFzrCCRY2WBzh7ui94S3wFWodQ+jtN2oCBeDML5mYft gGYXdwx2NpSBdm09KeHKgUEzj1qYlvdnhYlD26aXvxQF6VchwF5Zd1bpM9qETPcn/vAF N3Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=e/+C0/U/7T8ETxCupoulTe1zya9/ISeKYAztNAzb164=; b=KPSM9DuxynOnXbBBEcnsuMjhfVLtSUnjOn2UpiWma2VfLX9FHBXFe8MbG3Twy4pvkA RUOwjbHOj6qDQXBvXKeQJNi4TcYGtrYxhZmXfz3T3UYNLQYA+lSRICC0DEi31Hx3eKNP 9NilF2aXB/W79w/KZaKGRDjHLG3dcRv4ceoxgb0ELIFr8BKyzGOVJyb8yT6j+KtalBkx tIj6Q9j8KaYj+ABfY5vpHGBXXnAkBD4GBiSHBQDxNbThBG4RHauFGTZF34QNMbxzSuGQ zt/lDeddRAwLCIe/RGR2uGokIR+dtDt80EjcyMAw3ZKbp2JQ/QwwTvY/YNu/+O01Q6mF Pdlg== X-Gm-Message-State: APjAAAUrESwq8Js+HRrec+qG4YpDZvknM8QSrnTVvifF9eZw5XNoTZOj r9IZYrTDoMD6he5pcuBzwwTWww== X-Received: by 2002:a63:d20f:: with SMTP id a15mr4164989pgg.268.1574264750264; Wed, 20 Nov 2019 07:45:50 -0800 (PST) Received: from localhost ([14.96.110.98]) by smtp.gmail.com with ESMTPSA id u20sm30558372pgo.50.2019.11.20.07.45.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2019 07:45:49 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org, edubezval@gmail.com, Amit Daniel Kachhap , Amit Kucheria , Bartlomiej Zolnierkiewicz , Daniel Lezcano , Guillaume La Roque , Heiko Stuebner , Javi Merino , Jonathan Hunter , Jun Nie , Krzysztof Kozlowski , Kukjin Kim , Matthias Brugger , Shawn Guo , Thierry Reding , Viresh Kumar , Zhang Rui Cc: linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH v2 06/11] thermal: mediatek: Appease the kernel-doc deity Date: Wed, 20 Nov 2019 21:15:15 +0530 Message-Id: X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org Replace a comment starting with /** by simply /* to avoid having it interpreted as a kernel-doc comment. Describe missing function parameters where needed. Fixes up the following warnings when compiled with make W=1: linux.git/drivers/thermal/mtk_thermal.c:374: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8173_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:413: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2701_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:443: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt2712_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:499: warning: cannot understand function prototype: 'const struct mtk_thermal_data mt8183_thermal_data = ' linux.git/drivers/thermal/mtk_thermal.c:529: warning: Function parameter or member 'sensno' not described in 'raw_to_mcelsius' Signed-off-by: Amit Kucheria Reviewed-by: Viresh Kumar --- drivers/thermal/mtk_thermal.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) -- 2.20.1 diff --git a/drivers/thermal/mtk_thermal.c b/drivers/thermal/mtk_thermal.c index acf4854cbb8b..76e30603d4d5 100644 --- a/drivers/thermal/mtk_thermal.c +++ b/drivers/thermal/mtk_thermal.c @@ -358,7 +358,7 @@ static const int mt7622_mux_values[MT7622_NUM_SENSORS] = { 0, }; static const int mt7622_vts_index[MT7622_NUM_SENSORS] = { VTS1 }; static const int mt7622_tc_offset[MT7622_NUM_CONTROLLER] = { 0x0, }; -/** +/* * The MT8173 thermal controller has four banks. Each bank can read up to * four temperature sensors simultaneously. The MT8173 has a total of 5 * temperature sensors. We use each bank to measure a certain area of the @@ -400,7 +400,7 @@ static const struct mtk_thermal_data mt8173_thermal_data = { .sensor_mux_values = mt8173_mux_values, }; -/** +/* * The MT2701 thermal controller has one bank, which can read up to * three temperature sensors simultaneously. The MT2701 has a total of 3 * temperature sensors. @@ -430,7 +430,7 @@ static const struct mtk_thermal_data mt2701_thermal_data = { .sensor_mux_values = mt2701_mux_values, }; -/** +/* * The MT2712 thermal controller has one bank, which can read up to * four temperature sensors simultaneously. The MT2712 has a total of 4 * temperature sensors. @@ -484,7 +484,7 @@ static const struct mtk_thermal_data mt7622_thermal_data = { .sensor_mux_values = mt7622_mux_values, }; -/** +/* * The MT8183 thermal controller has one bank for the current SW framework. * The MT8183 has a total of 6 temperature sensors. * There are two thermal controller to control the six sensor. @@ -495,7 +495,6 @@ static const struct mtk_thermal_data mt7622_thermal_data = { * data, and this indeed needs the temperatures of the individual banks * for making better decisions. */ - static const struct mtk_thermal_data mt8183_thermal_data = { .auxadc_channel = MT8183_TEMP_AUXADC_CHANNEL, .num_banks = MT8183_NUM_SENSORS_PER_ZONE, @@ -519,7 +518,8 @@ static const struct mtk_thermal_data mt8183_thermal_data = { /** * raw_to_mcelsius - convert a raw ADC value to mcelsius - * @mt: The thermal controller + * @mt: The thermal controller + * @sensno: sensor number * @raw: raw ADC value * * This converts the raw ADC value to mcelsius using the SoC specific