| Message ID | 20191121182410.2803533-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 86d4131dfabdf4bca27d96de6f271565f1a3a5c6 |
| Headers | show |
| Series | [oe,meta-oe] nodejs: libatomic patch should be target specific | expand |
On Thu, Nov 21, 2019 at 7:24 PM Khem Raj <raj.khem@gmail.com> wrote: > > host usually are using gcc/x86_64/aarch64 and all of them have gcc which > can support atomic intrinsics, but not all of them install libatomic by > default e.g. centos-7, so asking for libatomic unconditionally may not > work always > > Signed-off-by: Khem Raj <raj.khem@gmail.com> Fell over this today on Fedora and had to install libatomic. So Acked--by: Andreas Müller <schnitzeltony@gmail.com>
On Thu, Nov 21, 2019 at 12:49 PM Andreas Müller <schnitzeltony@gmail.com> wrote: > On Thu, Nov 21, 2019 at 7:24 PM Khem Raj <raj.khem@gmail.com> wrote: > > > > host usually are using gcc/x86_64/aarch64 and all of them have gcc which > > can support atomic intrinsics, but not all of them install libatomic by > > default e.g. centos-7, so asking for libatomic unconditionally may not > > work always > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > Fell over this today on Fedora and had to install libatomic. So > > Acked--by: Andreas Müller <schnitzeltony@gmail.com> I think the same on Fedora-29 Acked-by: Tim Orling <timothy.t.orling@linux.intel.com> > > -- > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel >
diff --git a/meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb b/meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb index 8c690ae7dc..e36995c258 100644 --- a/meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb +++ b/meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb @@ -18,10 +18,10 @@ COMPATIBLE_HOST_riscv32 = "null" SRC_URI = "http://nodejs.org/dist/v${PV}/node-v${PV}.tar.xz \ file://0001-Disable-running-gyp-files-for-bundled-deps.patch \ file://0004-Make-compatibility-with-gcc-4.8.patch \ - file://0005-Link-atomic-library.patch \ file://0007-v8-don-t-override-ARM-CFLAGS.patch \ " SRC_URI_append_class-target = " \ + file://0005-Link-atomic-library.patch \ file://0002-Using-native-torque.patch \ "
host usually are using gcc/x86_64/aarch64 and all of them have gcc which can support atomic intrinsics, but not all of them install libatomic by default e.g. centos-7, so asking for libatomic unconditionally may not work always Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-oe/recipes-devtools/nodejs/nodejs_10.17.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.24.0 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel