| Message ID | 20191204184028.14813-1-anibal.limon@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [PATCHv2] meta/recipes-graphics/waffle: Add inherit setuptools | expand |
On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote: > -inherit meson features_check lib_package bash-completion > +inherit meson setuptools3 features_check lib_package bash-completion > I don't think you actually need setuptools3 here, just target python3 dependency is enough. Alex <div dir="ltr"><div dir="ltr">On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <<a href="mailto:anibal.limon@linaro.org">anibal.limon@linaro.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-inherit meson features_check lib_package bash-completion<br> +inherit meson setuptools3 features_check lib_package bash-completion<br></blockquote><div><br></div><div>I don't think you actually need setuptools3 here, just target python3 dependency is enough.</div><div><br></div><div>Alex<br></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote: > On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote: > >> -inherit meson features_check lib_package bash-completion >> +inherit meson setuptools3 features_check lib_package bash-completion >> > > I don't think you actually need setuptools3 here, just target python3 > dependency is enough. > Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target. Anibal > > Alex > <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com">alex.kanavin@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-inherit meson features_check lib_package bash-completion<br> +inherit meson setuptools3 features_check lib_package bash-completion<br></blockquote><div><br></div><div>I don't think you actually need setuptools3 here, just target python3 dependency is enough.</div></div></div></blockquote><div><br></div><div>Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target.</div><div><br></div><div>Anibal</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Alex<br></div></div></div> </blockquote></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
But inheriting setuptools does bring in the target python as well, and it’s the target python that fixes the issue, not setuptools. Alex > On 4 Dec 2019, at 21.51, Anibal Limon <anibal.limon@linaro.org> wrote: > > > >> On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote: >>> On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote: >> >>> -inherit meson features_check lib_package bash-completion >>> +inherit meson setuptools3 features_check lib_package bash-completion >> >> I don't think you actually need setuptools3 here, just target python3 dependency is enough. > > Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target. > > Anibal > >> >> Alex <html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto">But inheriting setuptools does bring in the target python as well, and it’s the target python that fixes the issue, not setuptools.<br><br><div id="AppleMailSignature" dir="ltr">Alex</div><div dir="ltr"><br>On 4 Dec 2019, at 21.51, Anibal Limon <<a href="mailto:anibal.limon@linaro.org">anibal.limon@linaro.org</a>> wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <<a href="mailto:alex.kanavin@gmail.com">alex.kanavin@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <<a href="mailto:anibal.limon@linaro.org" target="_blank">anibal.limon@linaro.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">-inherit meson features_check lib_package bash-completion<br> +inherit meson setuptools3 features_check lib_package bash-completion<br></blockquote><div><br></div><div>I don't think you actually need setuptools3 here, just target python3 dependency is enough.</div></div></div></blockquote><div><br></div><div>Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target.</div><div><br></div><div>Anibal</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div class="gmail_quote"><div><br></div><div>Alex<br></div></div></div> </blockquote></div></div> </div></blockquote></body></html> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Wed, Dec 4, 2019 at 2:07 PM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > But inheriting setuptools does bring in the target python as well, and it’s the target python that fixes the issue, not setuptools. perhaps setuptools3-native in deps is enough. > > Alex > > On 4 Dec 2019, at 21.51, Anibal Limon <anibal.limon@linaro.org> wrote: > > > > On Wed, 4 Dec 2019 at 13:15, Alexander Kanavin <alex.kanavin@gmail.com> wrote: >> >> On Wed, 4 Dec 2019 at 20:04, Aníbal Limón <anibal.limon@linaro.org> wrote: >>> >>> -inherit meson features_check lib_package bash-completion >>> +inherit meson setuptools3 features_check lib_package bash-completion >> >> >> I don't think you actually need setuptools3 here, just target python3 dependency is enough. > > > Actually doesn't need python3 it needs python3-native with setuptools, not need to depend of python3 for the target. > > Anibal > >> >> >> Alex
diff --git a/meta/recipes-graphics/waffle/waffle_1.6.0.bb b/meta/recipes-graphics/waffle/waffle_1.6.0.bb index 52cb1df899..48caf207c3 100644 --- a/meta/recipes-graphics/waffle/waffle_1.6.0.bb +++ b/meta/recipes-graphics/waffle/waffle_1.6.0.bb @@ -9,7 +9,7 @@ SRC_URI[sha256sum] = "d9c899f710c50cfdd00f5f4cdfeaef0687d8497362239bdde93bed6c90 UPSTREAM_CHECK_URI = "http://www.waffle-gl.org/releases.html" -inherit meson features_check lib_package bash-completion +inherit meson setuptools3 features_check lib_package bash-completion # This should be overridden per-machine to reflect the capabilities of the GL # stack.
Fixes, ... | Program python3 found: YES (/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3) | | meson.build:36:0: ERROR: <ExternalProgram 'python3' -> ['/home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/recipe-sysroot-native/usr/bin/python3-native/python3']> is not a valid python or it is missing setuptools | | A full log can be found at /home/anibal.limon/linaro/oe-rpb-master/build-410c/tmp-rpb-glibc/work/aarch64-linaro-linux/waffle/1.6.0-r0/build/meson-logs/meson-log.txt | WARNING: exit code 1 from a shell command. ... Signed-off-by: Aníbal Limón <anibal.limon@linaro.org> --- meta/recipes-graphics/waffle/waffle_1.6.0.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)