diff mbox series

qemu: domain: raise an error when no emulator is found

Message ID e88a589e529eb7591969ebb2e5f8f8801f72fc66.1575915266.git.crobinso@redhat.com
State Accepted
Commit 97cafa610ecf5dc4316027be679b12366da57769
Headers show
Series qemu: domain: raise an error when no emulator is found | expand

Commit Message

Cole Robinson Dec. 9, 2019, 6:14 p.m. UTC 
$ cat f | grep -e arch -e emulator
    <type arch='mipsel'>hvm</type>
$ sudo virsh define f
error: Failed to define domain from f
error: An error occurred, but the cause is unknown

After:
$ sudo virsh define f
error: Failed to define domain from f
error: unsupported configuration: No emulator found for arch 'mipsel'

Signed-off-by: Cole Robinson <crobinso@redhat.com>

---
 src/qemu/qemu_domain.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

-- 
2.23.0

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Comments

Daniel P. Berrangé Dec. 9, 2019, 6:21 p.m. UTC | #1 
On Mon, Dec 09, 2019 at 01:14:26PM -0500, Cole Robinson wrote:
> $ cat f | grep -e arch -e emulator
>     <type arch='mipsel'>hvm</type>
> $ sudo virsh define f
> error: Failed to define domain from f
> error: An error occurred, but the cause is unknown
> 
> After:
> $ sudo virsh define f
> error: Failed to define domain from f
> error: unsupported configuration: No emulator found for arch 'mipsel'
> 
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
>  src/qemu/qemu_domain.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>

(assuming make check passes)

> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index a15364a71e..6f53e17b6a 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -4687,8 +4687,12 @@ qemuDomainDefPostParseBasic(virDomainDefPtr def,
>      /* check for emulator and create a default one if needed */
>      if (!def->emulator) {
>          if (!(def->emulator = virQEMUCapsGetDefaultEmulator(
> -                  driver->hostarch, def->os.arch)))
> +                  driver->hostarch, def->os.arch))) {
> +            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> +                           _("No emulator found for arch '%s'"),
> +                           virArchToString(def->os.arch));
>              return 1;
> +        }
>      }
>  
>      return 0;
> -- 
> 2.23.0
> 
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list

Regards,
Daniel
diff mbox series

Patch

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index a15364a71e..6f53e17b6a 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -4687,8 +4687,12 @@  qemuDomainDefPostParseBasic(virDomainDefPtr def,
     /* check for emulator and create a default one if needed */
     if (!def->emulator) {
         if (!(def->emulator = virQEMUCapsGetDefaultEmulator(
-                  driver->hostarch, def->os.arch)))
+                  driver->hostarch, def->os.arch))) {
+            virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
+                           _("No emulator found for arch '%s'"),
+                           virArchToString(def->os.arch));
             return 1;
+        }
     }
 
     return 0;