[4.14,048/267] regulator: Fix return value of _set_load() stub

Message ID 20191216174853.876135512@linuxfoundation.org
State New
Headers show
  • Untitled series #25722
Related show

Commit Message

Greg KH Dec. 16, 2019, 5:46 p.m.
From: Mark Brown <broonie@kernel.org>

[ Upstream commit f1abf67217de91f5cd3c757ae857632ca565099a ]

The stub implementation of _set_load() returns a mode value which is
within the bounds of valid return codes for success (the documentation
just says that failures are negative error codes) but not sensible or
what the actual implementation does.  Fix it to just return 0.

Reported-by: Cheng-Yi Chiang <cychiang@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Douglas Anderson <dianders@chromium.org>

Signed-off-by: Mark Brown <broonie@kernel.org>

Signed-off-by: Sasha Levin <sashal@kernel.org>

 include/linux/regulator/consumer.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/include/linux/regulator/consumer.h b/include/linux/regulator/consumer.h
index 25602afd48447..f3f76051e8b00 100644
--- a/include/linux/regulator/consumer.h
+++ b/include/linux/regulator/consumer.h
@@ -508,7 +508,7 @@  static inline int regulator_get_error_flags(struct regulator *regulator,
 static inline int regulator_set_load(struct regulator *regulator, int load_uA)
+	return 0;
 static inline int regulator_allow_bypass(struct regulator *regulator,