| Message ID | 20191218024810.2874990-2-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | dd69fafd7f2c51fb69df66dbeae7f5a4b092580c |
| Headers | show |
| Series | [oe,meta-multimedia,1/3] tinyalsa: fix installation libdir path to match multilibs | expand |
On Tue, Dec 17, 2019 at 06:48:09PM -0800, Khem Raj wrote: > Same issue happens with clang/mips64 so extend the gold fix to cover for > this case > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > --- > meta-oe/recipes-extended/libqb/libqb_1.0.5.bb | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > index b205186e0b..82503a168b 100644 > --- a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > +++ b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > @@ -22,9 +22,13 @@ S = "${WORKDIR}/git" > # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: error: conftest.ld: SECTIONS seen after other input files; try -T/--script > # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: internal error in write_sections, at ../../gold/reloc.cc:791 > # collect2: error: ld returned 1 exit status > -EXTRA_OECONF_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' --enable-nosection-fallback', '', d)}" > +NOSECTION_FALLBACK = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-nosection-fallback', '', d)}" > +NOSECTION_FALLBACK_toolchain-clang_mips64 = "--enable-nosection-fallback" >... Removing these fragile linker tricks is the main change in the 1.9.0 (pre-)release, upgrading might be a better option than collecting more cases where the removed code broke. cu Adrian -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
On Tue, Dec 17, 2019 at 7:23 PM Adrian Bunk <bunk@stusta.de> wrote: > > On Tue, Dec 17, 2019 at 06:48:09PM -0800, Khem Raj wrote: > > Same issue happens with clang/mips64 so extend the gold fix to cover for > > this case > > > > Signed-off-by: Khem Raj <raj.khem@gmail.com> > > --- > > meta-oe/recipes-extended/libqb/libqb_1.0.5.bb | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > > index b205186e0b..82503a168b 100644 > > --- a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > > +++ b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb > > @@ -22,9 +22,13 @@ S = "${WORKDIR}/git" > > # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: error: conftest.ld: SECTIONS seen after other input files; try -T/--script > > # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: internal error in write_sections, at ../../gold/reloc.cc:791 > > # collect2: error: ld returned 1 exit status > > -EXTRA_OECONF_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' --enable-nosection-fallback', '', d)}" > > +NOSECTION_FALLBACK = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-nosection-fallback', '', d)}" > > +NOSECTION_FALLBACK_toolchain-clang_mips64 = "--enable-nosection-fallback" > >... > > Removing these fragile linker tricks is the main change in the 1.9.0 its lot more than that and I am not planning to do major upgrade https://github.com/ClusterLabs/libqb/releases/tag/1.9.0 > (pre-)release, upgrading might be a better option than collecting more > cases where the removed code broke. > Certain when upgrade to 2.0 is done this will/should be reviewed. -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff --git a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb index b205186e0b..82503a168b 100644 --- a/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb +++ b/meta-oe/recipes-extended/libqb/libqb_1.0.5.bb @@ -22,9 +22,13 @@ S = "${WORKDIR}/git" # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: error: conftest.ld: SECTIONS seen after other input files; try -T/--script # WORKDIR/libqb/1.0.3+gitAUTOINC+c235284b5f-r0/recipe-sysroot-native/usr/bin/i586-oe-linux/../../libexec/i586-oe-linux/gcc/i586-oe-linux/8.1.0/ld: internal error in write_sections, at ../../gold/reloc.cc:791 # collect2: error: ld returned 1 exit status -EXTRA_OECONF_append = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' --enable-nosection-fallback', '', d)}" +NOSECTION_FALLBACK = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', '--enable-nosection-fallback', '', d)}" +NOSECTION_FALLBACK_toolchain-clang_mips64 = "--enable-nosection-fallback" + +EXTRA_OECONF += "${NOSECTION_FALLBACK}" CFLAGS += "-pthread -D_REENTRANT" + do_configure_prepend() { ( cd ${S} ${S}/autogen.sh )
Same issue happens with clang/mips64 so extend the gold fix to cover for this case Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta-oe/recipes-extended/libqb/libqb_1.0.5.bb | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.24.1 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel