[4/4] phy: qcom-qmp: remove duplicate powerdown write

Message ID 20191219150433.2785427-5-vkoul@kernel.org
State Superseded
Headers show
Series
  • phy: qcom-qmp: Fixes and updates for sm8150
Related show

Commit Message

Vinod Koul Dec. 19, 2019, 3:04 p.m.
We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init()
before invoking qcom_qmp_phy_configure() so remove the duplicate write.

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 1 -
 1 file changed, 1 deletion(-)

-- 
2.23.0

Comments

Jeffrey Hugo Dec. 19, 2019, 3:31 p.m. | #1
On Thu, Dec 19, 2019 at 8:05 AM Vinod Koul <vkoul@kernel.org> wrote:
>

> We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init()

> before invoking qcom_qmp_phy_configure() so remove the duplicate write.

>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>


Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>


> ---

>  drivers/phy/qualcomm/phy-qcom-qmp.c | 1 -

>  1 file changed, 1 deletion(-)

>

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c

> index 80304b7cd895..309ef15e46b0 100644

> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c

> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c

> @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = {

>  };

>

>  static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = {

> -       QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01),

>         QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9),

>         QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11),

>         QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),

> --

> 2.23.0

>

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 80304b7cd895..309ef15e46b0 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -885,7 +885,6 @@  static const struct qmp_phy_init_tbl msm8998_usb3_pcs_tbl[] = {
 };
 
 static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = {
-	QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01),
 	QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9),
 	QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11),
 	QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),