diff mbox series

[v2,2/5] phy: qcom-qmp: Use register defines

Message ID 20191220101719.3024693-3-vkoul@kernel.org
State Superseded
Headers show
Series phy: qcom-qmp: Fixes and updates for sm8150 | expand

Commit Message

Vinod Koul Dec. 20, 2019, 10:17 a.m. UTC 
We already define register offsets so use them in register layout.

Signed-off-by: Vinod Koul <vkoul@kernel.org>

Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

---
 drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.23.0

Comments

Can Guo Dec. 23, 2019, 8:43 a.m. UTC | #1 
On 2019-12-20 18:17, Vinod Koul wrote:
> We already define register offsets so use them in register layout.

> 

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>

> ---

>  drivers/phy/qualcomm/phy-qcom-qmp.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c

> b/drivers/phy/qualcomm/phy-qcom-qmp.c

> index 66f91726b8b2..1196c85aa023 100644

> --- a/drivers/phy/qualcomm/phy-qcom-qmp.c

> +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c

> @@ -166,8 +166,8 @@ static const unsigned int 

> sdm845_ufsphy_regs_layout[] = {

>  };

> 

>  static const unsigned int sm8150_ufsphy_regs_layout[] = {

> -	[QPHY_START_CTRL]		= 0x00,

> -	[QPHY_PCS_READY_STATUS]		= 0x180,

> +	[QPHY_START_CTRL]		= QPHY_V4_PHY_START,

> +	[QPHY_PCS_READY_STATUS]		= QPHY_V4_PCS_READY_STATUS,


Missed QPHY_SW_RESET?

Regards,
Can Guo.

>  };

> 

>  static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {
diff mbox series

Patch

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c
index 66f91726b8b2..1196c85aa023 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp.c
@@ -166,8 +166,8 @@  static const unsigned int sdm845_ufsphy_regs_layout[] = {
 };
 
 static const unsigned int sm8150_ufsphy_regs_layout[] = {
-	[QPHY_START_CTRL]		= 0x00,
-	[QPHY_PCS_READY_STATUS]		= 0x180,
+	[QPHY_START_CTRL]		= QPHY_V4_PHY_START,
+	[QPHY_PCS_READY_STATUS]		= QPHY_V4_PCS_READY_STATUS,
 };
 
 static const struct qmp_phy_init_tbl msm8996_pcie_serdes_tbl[] = {