From patchwork Sun Dec 29 17:22:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 182575 Delivered-To: patch@linaro.org Received: by 2002:a92:815a:0:0:0:0:0 with SMTP id e87csp5479058ild; Sun, 29 Dec 2019 10:08:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxfTxRrJQsjRk/OXY5+YeW27DnEkFkYNBFnZdpQpf9SBJhcxnlHgb4o+7nBpnHi2DK/g185 X-Received: by 2002:a9d:7f11:: with SMTP id j17mr72462690otq.281.1577642939317; Sun, 29 Dec 2019 10:08:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577642939; cv=none; d=google.com; s=arc-20160816; b=d9UUrM9/GxlQoWRLCymyilRmkGJZlTO+dQk78Z6khLrJ5NE0BazLU4Gxp/C5KkbJ0B 9/XXwh1RXucy2zrPHK/BV9UzrGdVz10d9xjfSuKCMc/OmHGM7T0stQbrZ7tVCRGM32qh itW4QT/nvhfYsWUOxKvG/XKYijgk4f/uQgmMtooW326vqogiDv7kvDe4zdNuenJjHBfJ PHQWxml5siHt/2JrJX9USLQ/LYS5zkoAPYyorKUcp5kHTe0vOxl77Df05re7Ynz3Xu71 a0eeADLvrrXKEovLuxu3sdsHuI76S7ptSdxBVUTm/16gLorPqREDGOvmkfkL0zPqaXKh V9Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=jzyWak/eyZBW5h4nuUxRdgBUeXlBeK+1tDjtdRcUCbc=; b=pKt0MbfK9GpY2MtZgUA8oPYrncKhLuqC4sjF8XFAFbnqb3NcGQ0/BO3MxzjcTs/5NE Wl5qRV68z4tehioa3pQ2X4kGG9OSHX1bUdsUdAKKa4esbTjzaStkkAceJU3AnFtnzx2t IsXBPnHNBIyassVgZlnXNHbRSHBODdBNW+ZpD1/MYZnBaYh7mP5t/huLopuORFCePHsP XKcl+aD7NWBgzDu8KMtyXWxQPAo0ExWAf2/myOZfTRKuewN+NOAlMvhYSkZ1xQ1JFTNK a1PxxtF6gc5iWTE9BjdKe15wVnMCKIBIO8I0TZZaQJZP+/OMrqCT6Q+AsqkC6E9Uv5OC MOnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MID9bwUA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r2si9358694oif.83.2019.12.29.10.08.58; Sun, 29 Dec 2019 10:08:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MID9bwUA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731083AbfL2Rq3 (ORCPT + 27 others); Sun, 29 Dec 2019 12:46:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:56060 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731059AbfL2RqW (ORCPT ); Sun, 29 Dec 2019 12:46:22 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 02C45207FD; Sun, 29 Dec 2019 17:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577641581; bh=7n4dLVhug/MW4tU0tHSU9xP1KOHu9yfjbj2Fml1wVEs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MID9bwUAVAHuZiKGFir+8JKd7FnvZBSY1eKWiGhvAktyRinaJ6pnJDz1rjrgvvCfa 3zk3au3HafgKLR5p2azZ5+WdrWCedoxalgA9bcyc7++JRJtTkCG7/1ryKTtQitw+sZ wY76eZSqq0syV7jQ9zD2IbP9oBExzgiLWRP4ICAg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Bjorn Andersson , Sasha Levin Subject: [PATCH 5.4 125/434] misc: fastrpc: fix memory leak from miscdev->name Date: Sun, 29 Dec 2019 18:22:58 +0100 Message-Id: <20191229172710.001573260@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191229172702.393141737@linuxfoundation.org> References: <20191229172702.393141737@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Srinivas Kandagatla [ Upstream commit 2d10d2d170723e9278282458a6704552dcb77eac ] Fix a memory leak in miscdev->name by using devm_variant Orignally reported by kmemleak: [] kmemleak_alloc+0x50/0x84 [] __kmalloc_track_caller+0xe8/0x168 [] kvasprintf+0x78/0x100 [] kasprintf+0x50/0x74 [] fastrpc_rpmsg_probe+0xd8/0x20c [] rpmsg_dev_probe+0xa8/0x148 [] really_probe+0x208/0x248 [] driver_probe_device+0x98/0xc0 [] __device_attach_driver+0x9c/0xac [] bus_for_each_drv+0x60/0x8c [] __device_attach+0x8c/0x100 [] device_initial_probe+0x20/0x28 [] bus_probe_device+0x34/0x7c [] device_add+0x420/0x498 [] device_register+0x24/0x2c Signed-off-by: Srinivas Kandagatla Reviewed-by: Bjorn Andersson Link: https://lore.kernel.org/r/20191009144123.24583-3-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/misc/fastrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.1 diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1b1a794d639d..842f2210dc7e 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -1430,8 +1430,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) return -ENOMEM; data->miscdev.minor = MISC_DYNAMIC_MINOR; - data->miscdev.name = kasprintf(GFP_KERNEL, "fastrpc-%s", - domains[domain_id]); + data->miscdev.name = devm_kasprintf(rdev, GFP_KERNEL, "fastrpc-%s", + domains[domain_id]); data->miscdev.fops = &fastrpc_fops; err = misc_register(&data->miscdev); if (err)