[v4,1/2] doc/rcu: correct quiescent state description

Message ID 20200219210530.22863-1-honnappa.nagarahalli@arm.com
State New
Headers show
Series
  • [v4,1/2] doc/rcu: correct quiescent state description
Related show

Commit Message

Honnappa Nagarahalli Feb. 19, 2020, 9:05 p.m.
The quiescent state description refers to an incorrect
thread.

Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")
Cc: stable@dpdk.org

Signed-off-by: Prateek Agarwal <prateekag@cse.iitb.ac.in>

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

---
V4
1) Seperated the commits for ring and RCU changes
2) Changed the commit logs

 doc/guides/prog_guide/rcu_lib.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Honnappa Nagarahalli Feb. 19, 2020, 11:35 p.m. | #1
> -----Original Message-----

> From: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

> Sent: Wednesday, February 19, 2020 3:05 PM

> To: olivier.matz@6wind.com; prateekag@cse.iitb.ac.in; ferruh.yigit@intel.com;

> thomas@monjalon.net

> Cc: dev@dpdk.org; nd <nd@arm.com>; Honnappa Nagarahalli

> <Honnappa.Nagarahalli@arm.com>; stable@dpdk.org

> Subject: [PATCH v4 1/2] doc/rcu: correct quiescent state description

> 

> The quiescent state description refers to an incorrect thread.

> 

> Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")

> Cc: stable@dpdk.org

> 

> Signed-off-by: Prateek Agarwal <prateekag@cse.iitb.ac.in>

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>

Tested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>


> ---

> V4

> 1) Seperated the commits for ring and RCU changes

> 2) Changed the commit logs

> 

>  doc/guides/prog_guide/rcu_lib.rst | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/doc/guides/prog_guide/rcu_lib.rst

> b/doc/guides/prog_guide/rcu_lib.rst

> index 8d0dfcf29..9b0bf138f 100644

> --- a/doc/guides/prog_guide/rcu_lib.rst

> +++ b/doc/guides/prog_guide/rcu_lib.rst

> @@ -61,7 +61,7 @@ wait till thread 2 enters quiescent state as well.

> 

>  However, the writer does not need to wait for reader thread 3 to enter

> quiescent state. Reader thread 3 was not accessing D1 when the delete -

> operation happened. So, reader thread 1 will not have a reference to the

> +operation happened. So, reader thread 3 will not have a reference to

> +the

>  deleted entry.

> 

>  It can be noted that, the critical sections for D2 is a quiescent state

> --

> 2.17.1
Thomas Monjalon Feb. 21, 2020, 5:31 p.m. | #2
19/02/2020 22:05, Honnappa Nagarahalli:
> The quiescent state description refers to an incorrect

> thread.

> 

> Fixes: 64994b56cfd7 ("rcu: add RCU library supporting QSBR mechanism")

> Cc: stable@dpdk.org

> 

> Signed-off-by: Prateek Agarwal <prateekag@cse.iitb.ac.in>

> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>


Series applied, thanks

Patch

diff --git a/doc/guides/prog_guide/rcu_lib.rst b/doc/guides/prog_guide/rcu_lib.rst
index 8d0dfcf29..9b0bf138f 100644
--- a/doc/guides/prog_guide/rcu_lib.rst
+++ b/doc/guides/prog_guide/rcu_lib.rst
@@ -61,7 +61,7 @@  wait till thread 2 enters quiescent state as well.
 
 However, the writer does not need to wait for reader thread 3 to enter
 quiescent state. Reader thread 3 was not accessing D1 when the delete
-operation happened. So, reader thread 1 will not have a reference to the
+operation happened. So, reader thread 3 will not have a reference to the
 deleted entry.
 
 It can be noted that, the critical sections for D2 is a quiescent state