| Message ID | 20200226101119.16578-1-m.szyprowski@samsung.com |
|---|---|
| State | New |
| Headers | show |
| Series | drm/exynos: dsi: silence warning about regulators during deferred probe | expand |
On Wed, 26 Feb 2020 at 11:11, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Don't confuse user with meaningless warning about failure in getting > regulators in case of deferred probe. You are doing actually more than you explained here. You fixed inaccurate error code (EPROBE_DEFER) being returned in case of failures of getting regulators. This change makes sense but commit message looks too innocent. Best regards, Krzysztof > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 08a8ce3f499c..a85365c56d4d 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1773,8 +1773,9 @@ static int exynos_dsi_probe(struct platform_device *pdev) > ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dsi->supplies), > dsi->supplies); > if (ret) { > - dev_info(dev, "failed to get regulators: %d\n", ret); > - return -EPROBE_DEFER; > + if (ret != -EPROBE_DEFER) > + dev_info(dev, "failed to get regulators: %d\n", ret); > + return ret; > } > > dsi->clks = devm_kcalloc(dev, > -- > 2.17.1 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 08a8ce3f499c..a85365c56d4d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1773,8 +1773,9 @@ static int exynos_dsi_probe(struct platform_device *pdev) ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(dsi->supplies), dsi->supplies); if (ret) { - dev_info(dev, "failed to get regulators: %d\n", ret); - return -EPROBE_DEFER; + if (ret != -EPROBE_DEFER) + dev_info(dev, "failed to get regulators: %d\n", ret); + return ret; } dsi->clks = devm_kcalloc(dev,
Don't confuse user with meaningless warning about failure in getting regulators in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/gpu/drm/exynos/exynos_drm_dsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.17.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel