| Message ID | 1374152070-21008-1-git-send-email-daniel.lezcano@linaro.org |
|---|---|
| State | New |
| Headers | show |
Hi Daniel, On Thursday 18 of July 2013 14:54:27 Daniel Lezcano wrote: > When there are several cpus online, the AFTR state does not work. > > The AFTR must be selected only when there is one cpu online. > > The previous code was already handling this case. > > Simplified the code, especially the init routine to have the same init > pattern than the other drivers. > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > arch/arm/mach-exynos/cpuidle.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/mach-exynos/cpuidle.c > b/arch/arm/mach-exynos/cpuidle.c index 17a18ff..cc4b097 100644 > --- a/arch/arm/mach-exynos/cpuidle.c > +++ b/arch/arm/mach-exynos/cpuidle.c > @@ -147,16 +147,11 @@ static int exynos4_enter_lowpower(struct > cpuidle_device *dev, struct cpuidle_driver *drv, > int index) > { > - int new_index = index; > - > /* This mode only can be entered when other core's are offline */ > if (num_online_cpus() > 1) > - new_index = drv->safe_state_index; > + return drv->states[0].enter(dev, drv, 0); > > - if (new_index == 0) > - return arm_cpuidle_simple_enter(dev, drv, new_index); > - else > - return exynos4_enter_core0_aftr(dev, drv, new_index); > + return exynos4_enter_core0_aftr(dev, drv, index); > } > > static void __init exynos5_core_down_clk(void) > @@ -209,10 +204,6 @@ static int __init exynos4_init_cpuidle(void) > device = &per_cpu(exynos4_cpuidle_device, cpu_id); > device->cpu = cpu_id; > > - /* Support IDLE only */ > - if (cpu_id != 0) > - device->state_count = 1; > - Are you sure that this is okay? It means, assuming that you have CPU0 hotplug enabled, that you can enter the AFTR state if _any_ single core remains plugged in, which is technically possible, but then wake-up will occur on CPU0, which is not what cpuidle and hotplug code expect. P.S. Please keep linux-samsung-soc@vger.kernel.org mailing list on Cc for patches related to Samsung SoCs. Best regards, Tomasz
On Wednesday, July 24, 2013 10:32:47 AM Tomasz Figa wrote: > Hi Daniel, > > On Thursday 18 of July 2013 14:54:27 Daniel Lezcano wrote: > > When there are several cpus online, the AFTR state does not work. > > > > The AFTR must be selected only when there is one cpu online. > > > > The previous code was already handling this case. > > > > Simplified the code, especially the init routine to have the same init > > pattern than the other drivers. > > > > Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> > > --- > > arch/arm/mach-exynos/cpuidle.c | 13 ++----------- > > 1 file changed, 2 insertions(+), 11 deletions(-) > > > > diff --git a/arch/arm/mach-exynos/cpuidle.c > > b/arch/arm/mach-exynos/cpuidle.c index 17a18ff..cc4b097 100644 > > --- a/arch/arm/mach-exynos/cpuidle.c > > +++ b/arch/arm/mach-exynos/cpuidle.c > > @@ -147,16 +147,11 @@ static int exynos4_enter_lowpower(struct > > cpuidle_device *dev, struct cpuidle_driver *drv, > > int index) > > { > > - int new_index = index; > > - > > /* This mode only can be entered when other core's are offline */ > > if (num_online_cpus() > 1) > > - new_index = drv->safe_state_index; > > + return drv->states[0].enter(dev, drv, 0); > > > > - if (new_index == 0) > > - return arm_cpuidle_simple_enter(dev, drv, new_index); > > - else > > - return exynos4_enter_core0_aftr(dev, drv, new_index); > > + return exynos4_enter_core0_aftr(dev, drv, index); > > } > > > > static void __init exynos5_core_down_clk(void) > > @@ -209,10 +204,6 @@ static int __init exynos4_init_cpuidle(void) > > device = &per_cpu(exynos4_cpuidle_device, cpu_id); > > device->cpu = cpu_id; > > > > - /* Support IDLE only */ > > - if (cpu_id != 0) > > - device->state_count = 1; > > - > > Are you sure that this is okay? It means, assuming that you have CPU0 > hotplug enabled, that you can enter the AFTR state if _any_ single core > remains plugged in, which is technically possible, but then wake-up will > occur on CPU0, which is not what cpuidle and hotplug code expect. I worry that the current code is already broken in this respect as cpuidle core is using driver->state_count for everything except creating/destroying sysfs state entries. This is probably something that needs to be fixed in the cpuidle core (I suspect that governors should use device->state_count instead of driver->state_count but it would need confirmation from someone that knows this code better) but in the meantime it could be fixed by adding CPU0 check to exynos4_enter_lowpower() (if the last CPU != 0 then don't go into AFTR mode). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > P.S. Please keep linux-samsung-soc@vger.kernel.org mailing list on Cc for > patches related to Samsung SoCs. > > Best regards, > Tomasz
diff --git a/arch/arm/mach-exynos/cpuidle.c b/arch/arm/mach-exynos/cpuidle.c index 17a18ff..cc4b097 100644 --- a/arch/arm/mach-exynos/cpuidle.c +++ b/arch/arm/mach-exynos/cpuidle.c @@ -147,16 +147,11 @@ static int exynos4_enter_lowpower(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - int new_index = index; - /* This mode only can be entered when other core's are offline */ if (num_online_cpus() > 1) - new_index = drv->safe_state_index; + return drv->states[0].enter(dev, drv, 0); - if (new_index == 0) - return arm_cpuidle_simple_enter(dev, drv, new_index); - else - return exynos4_enter_core0_aftr(dev, drv, new_index); + return exynos4_enter_core0_aftr(dev, drv, index); } static void __init exynos5_core_down_clk(void) @@ -209,10 +204,6 @@ static int __init exynos4_init_cpuidle(void) device = &per_cpu(exynos4_cpuidle_device, cpu_id); device->cpu = cpu_id; - /* Support IDLE only */ - if (cpu_id != 0) - device->state_count = 1; - ret = cpuidle_register_device(device); if (ret) { printk(KERN_ERR "CPUidle register device failed\n");
When there are several cpus online, the AFTR state does not work. The AFTR must be selected only when there is one cpu online. The previous code was already handling this case. Simplified the code, especially the init routine to have the same init pattern than the other drivers. Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> --- arch/arm/mach-exynos/cpuidle.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)