From patchwork Thu Mar 5 14:01:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Adhemerval Zanella Netto X-Patchwork-Id: 184194 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp6205466ile; Thu, 5 Mar 2020 06:01:38 -0800 (PST) X-Google-Smtp-Source: ADFU+vuGmEklqc6xZ8Dfu9ctS1EhtodKD5bnffHE/L2bkSuCA2bTufEyiWCQTMce0WNFc70H4M25 X-Received: by 2002:a05:6830:1e46:: with SMTP id e6mr6576555otj.257.1583416898204; Thu, 05 Mar 2020 06:01:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1583416898; cv=none; d=google.com; s=arc-20160816; b=UzXnYSzBP6GnUrFDXkFHo3VuQf1c+Cc9u/8zIQJKnxtDrsh/2eqv3bTtP8P3JYmhSA MWopMrNC1Es23g+AHXopJbnYKjNd6oxvlSDf/TLuPRLNrvhz3gZIDrcXV90knG6HczXk qL0yKMqhpXjdNzDXJKNRYGOHwEPVZd8qPv6U7PcTWk4exiqdjIu/A+TshEkbBvEiVQoJ pFr2pJHMIvRazpN6cmgaqQsSbg8egYrFXOc+CkgaMesVtkQTjg8K2YKViqQcQ07CIdo7 wkS8gnCS5opZAm1437D6UW0EsHDPhvb5ZSzqgFR2OXJINA9tRbPkTswjkjVHk2SFmL1Y Ccyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from :dkim-signature:delivered-to:sender:list-help:list-post:list-archive :list-subscribe:list-unsubscribe:list-id:precedence:mailing-list :dkim-signature:domainkey-signature; bh=wey0csPxmJBrSwm8ExPnmgRut4jgQ88OC24DDIRNyww=; b=ssxVcyHP9PHrnHrMyavQJ/yN5j9Btz7Dm5efCV8Y+soU4OJwNIKbx1wr1XRAVJPnQS CgiW33FuerYz3atkXvzDI9PQYQIz30Co07CrIHs2N/48qj4Ejc/rvwJZ+QwaU4xzcfyM b5ziQP7vm6pzpzfV/qD47ghZlgNKPcJk4190YfGlzLE9No2EUGeHL8G1QyJtgWXR//dS X4dzE7t1B0bxbitN+EOIbesIGQsY904zM4JB1q8ZxGKxqLfHO/Z4eBcqQ34CQSDNC1R2 d9jXLAPUHZUOlLdn/XLMhvYbxz0GKsvRIYcJbgImf/wGcjZJvNnGvjXeGZDkNcPLT2Oi p5zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="U7K2Cn/t"; dkim=pass header.i=@linaro.org header.s=google header.b=b9zPSYyQ; spf=pass (google.com: domain of libc-alpha-return-110308-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-110308-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sourceware.org (server1.sourceware.org. [209.132.180.131]) by mx.google.com with ESMTPS id i6si2593536otc.284.2020.03.05.06.01.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Mar 2020 06:01:38 -0800 (PST) Received-SPF: pass (google.com: domain of libc-alpha-return-110308-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) client-ip=209.132.180.131; Authentication-Results: mx.google.com; dkim=pass header.i=@sourceware.org header.s=default header.b="U7K2Cn/t"; dkim=pass header.i=@linaro.org header.s=google header.b=b9zPSYyQ; spf=pass (google.com: domain of libc-alpha-return-110308-patch=linaro.org@sourceware.org designates 209.132.180.131 as permitted sender) smtp.mailfrom="libc-alpha-return-110308-patch=linaro.org@sourceware.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; q=dns; s=default; b=oCzcPeWohWs9T2PzqrKvg9mpLIqOGrp wIlc7jIYrqkmMZ+JjO/kmwilljMtM3+EPgp3VY+pVuuDCwUTiDOrDC9FTLCI/Fwt MqGdOqWepud6U8SeUP5jPvQkH1SkxTA5CnRXrv4u2fRJpf0Ho3XazAy/UOwX+iBJ wbYlotrKhkpA= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:subject:date:message-id:in-reply-to :references; s=default; bh=Z5sPnjEYwm38einc/J7Xx/rbrS4=; b=U7K2C n/tCfWElG3diVm7+Ccz/vq/frtFdROSf+IQXL712MWjN3NrG3ghFa/cSzIcsNq9B U5M0bTMAwdvmLtkSK6t6LGH0uoHXSRGb0BafKaQQwa8i9LGQkPCP/+0dP74PCOTv 2yBD88B4hwtUjAIKA1REBWrtsTAQcOUZLNtTI4= Received: (qmail 76323 invoked by alias); 5 Mar 2020 14:01:27 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 75057 invoked by uid 89); 5 Mar 2020 14:01:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-22.3 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-qk1-f193.google.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references; bh=wey0csPxmJBrSwm8ExPnmgRut4jgQ88OC24DDIRNyww=; b=b9zPSYyQgHgj9qhWbe8kTLRxhwqt2TyO5eeU8r4Ad+OyTjRIYKPOEokH9Oa7ULkvd+ 4tymbaZsyDHqZqEB5dhOGwop+1hvHMSzuF9fqUZEIsGq2x4wO4Y6XxkyuhHygy2tO1Vr jsdDck31XThmLNkc7FDVUivl8NjtKER2rwKWq5fMGkU30h6WSxhiQ6ZL0HAk/0nD6khA GU8JMMBj+g6dJbhowJWdNwZqOQpfczdUYJVcOxsWpTVPUYfYRXKFr37ZiRx1jU0wo9gk SfyR3rrhOSdYX0ukObn8dTDU1LsNBQd/99QxwojVDUQLJmKa284jUEQXC6oqCXuEdb3W HFuQ== Return-Path: From: Adhemerval Zanella To: libc-alpha@sourceware.org Subject: [PATCH v2 2/2] arm: Fix softp-fp Implies (BZ #25635) Date: Thu, 5 Mar 2020 11:01:05 -0300 Message-Id: <20200305140105.22734-2-adhemerval.zanella@linaro.org> In-Reply-To: <20200305140105.22734-1-adhemerval.zanella@linaro.org> References: <20200305140105.22734-1-adhemerval.zanella@linaro.org> Changes from previous version: - Remove wrong --without-fp mention. - Change the order on generic sysdep Implies instead of Linux one. -- The commit "arm: Split BE/LE abilist" (1673ba87fefe019c834c09d33673d1d453ea698d) changed the soft-fp order for ARM selection when __SOFTFP__ is defined by the compiler. On 2.31 the sysdeps order is: 2.31 sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic While on master is: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptl sysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/ieee754 sysdeps/generic It make the build select some routines (fadd, fdiv, fmul, fsub, and fma) on ieee754/flt-32 and ieee754/dbl-64 that requires fenv support to be correctly rounded which in turns lead to math failures since the __SOFTFP__ does not have fenv support. With this patch the order is now: sysdeps/unix/sysv/linux/arm/le sysdeps/unix/sysv/linux/arm sysdeps/arm/nptl sysdeps/unix/sysv/linux sysdeps/nptlsysdeps/pthread sysdeps/gnu sysdeps/unix/inet sysdeps/unix/sysv sysdeps/unix/arm sysdeps/unix sysdeps/posix sysdeps/arm/le/nofpu sysdeps/arm/nofpu sysdeps/ieee754/soft-fp sysdeps/arm/le sysdeps/arm sysdeps/wordsize-32 sysdeps/ieee754/flt-32 sysdeps/ieee754/dbl-64 sysdeps/ieee754 sysdeps/generic Checked on arm-linux-gnuaebi. --- sysdeps/arm/be/nofpu/Implies | 1 + sysdeps/arm/le/nofpu/Implies | 1 + 2 files changed, 2 insertions(+) create mode 100644 sysdeps/arm/be/nofpu/Implies create mode 100644 sysdeps/arm/le/nofpu/Implies -- 2.17.1 diff --git a/sysdeps/arm/be/nofpu/Implies b/sysdeps/arm/be/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/be/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu diff --git a/sysdeps/arm/le/nofpu/Implies b/sysdeps/arm/le/nofpu/Implies new file mode 100644 index 0000000000..c90dd7fd5c --- /dev/null +++ b/sysdeps/arm/le/nofpu/Implies @@ -0,0 +1 @@ +arm/nofpu