diff mbox series

[for-5.0,v2,1/3] acpi: Use macro for table-loader file name

Message ID 20200403101827.30664-2-shameerali.kolothum.thodi@huawei.com
State Accepted
Commit bac78f9c692ff397e365d552e390b674925bd243
Headers show
Series acpi: Fixes for inconsistency in ACPI MR size during migration | expand

Commit Message

Shameerali Kolothum Thodi April 3, 2020, 10:18 a.m. UTC
Use macro for "etc/table-loader" and move it to the header
file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc.

Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>

Reviewed-by: Igor Mammedov <imammedo@redhat.com>

---
 hw/arm/virt-acpi-build.c    | 2 +-
 hw/i386/acpi-build.c        | 2 +-
 include/hw/acpi/aml-build.h | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.17.1

Comments

Philippe Mathieu-Daudé April 3, 2020, 10:45 a.m. UTC | #1
On 4/3/20 12:18 PM, Shameer Kolothum wrote:
> Use macro for "etc/table-loader" and move it to the header

> file similar to ACPI_BUILD_TABLE_FILE/ACPI_BUILD_RSDP_FILE etc.

> 

> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>

> Reviewed-by: Igor Mammedov <imammedo@redhat.com>


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


> ---

>   hw/arm/virt-acpi-build.c    | 2 +-

>   hw/i386/acpi-build.c        | 2 +-

>   include/hw/acpi/aml-build.h | 1 +

>   3 files changed, 3 insertions(+), 2 deletions(-)

> 

> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c

> index 7ef0733d71..81d41a3990 100644

> --- a/hw/arm/virt-acpi-build.c

> +++ b/hw/arm/virt-acpi-build.c

> @@ -929,7 +929,7 @@ void virt_acpi_setup(VirtMachineState *vms)

>   

>       build_state->linker_mr =

>           acpi_add_rom_blob(virt_acpi_build_update, build_state,

> -                          tables.linker->cmd_blob, "etc/table-loader", 0);

> +                          tables.linker->cmd_blob, ACPI_BUILD_LOADER_FILE, 0);

>   

>       fw_cfg_add_file(vms->fw_cfg, ACPI_BUILD_TPMLOG_FILE, tables.tcpalog->data,

>                       acpi_data_len(tables.tcpalog));

> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

> index 2a7e55bae7..23c77eeb95 100644

> --- a/hw/i386/acpi-build.c

> +++ b/hw/i386/acpi-build.c

> @@ -3043,7 +3043,7 @@ void acpi_setup(void)

>   

>       build_state->linker_mr =

>           acpi_add_rom_blob(acpi_build_update, build_state,

> -                          tables.linker->cmd_blob, "etc/table-loader", 0);

> +                          tables.linker->cmd_blob, ACPI_BUILD_LOADER_FILE, 0);

>   

>       fw_cfg_add_file(x86ms->fw_cfg, ACPI_BUILD_TPMLOG_FILE,

>                       tables.tcpalog->data, acpi_data_len(tables.tcpalog));

> diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h

> index de4a406568..0f4ed53d7f 100644

> --- a/include/hw/acpi/aml-build.h

> +++ b/include/hw/acpi/aml-build.h

> @@ -13,6 +13,7 @@

>   #define ACPI_BUILD_TABLE_FILE "etc/acpi/tables"

>   #define ACPI_BUILD_RSDP_FILE "etc/acpi/rsdp"

>   #define ACPI_BUILD_TPMLOG_FILE "etc/tpm/log"

> +#define ACPI_BUILD_LOADER_FILE "etc/table-loader"

>   

>   #define AML_NOTIFY_METHOD "NTFY"

>   

>
diff mbox series

Patch

diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 7ef0733d71..81d41a3990 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw/arm/virt-acpi-build.c
@@ -929,7 +929,7 @@  void virt_acpi_setup(VirtMachineState *vms)
 
     build_state->linker_mr =
         acpi_add_rom_blob(virt_acpi_build_update, build_state,
-                          tables.linker->cmd_blob, "etc/table-loader", 0);
+                          tables.linker->cmd_blob, ACPI_BUILD_LOADER_FILE, 0);
 
     fw_cfg_add_file(vms->fw_cfg, ACPI_BUILD_TPMLOG_FILE, tables.tcpalog->data,
                     acpi_data_len(tables.tcpalog));
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 2a7e55bae7..23c77eeb95 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -3043,7 +3043,7 @@  void acpi_setup(void)
 
     build_state->linker_mr =
         acpi_add_rom_blob(acpi_build_update, build_state,
-                          tables.linker->cmd_blob, "etc/table-loader", 0);
+                          tables.linker->cmd_blob, ACPI_BUILD_LOADER_FILE, 0);
 
     fw_cfg_add_file(x86ms->fw_cfg, ACPI_BUILD_TPMLOG_FILE,
                     tables.tcpalog->data, acpi_data_len(tables.tcpalog));
diff --git a/include/hw/acpi/aml-build.h b/include/hw/acpi/aml-build.h
index de4a406568..0f4ed53d7f 100644
--- a/include/hw/acpi/aml-build.h
+++ b/include/hw/acpi/aml-build.h
@@ -13,6 +13,7 @@ 
 #define ACPI_BUILD_TABLE_FILE "etc/acpi/tables"
 #define ACPI_BUILD_RSDP_FILE "etc/acpi/rsdp"
 #define ACPI_BUILD_TPMLOG_FILE "etc/tpm/log"
+#define ACPI_BUILD_LOADER_FILE "etc/table-loader"
 
 #define AML_NOTIFY_METHOD "NTFY"