diff mbox series

[v1,07/11] configure: disable PIE for Windows builds

Message ID 20200409211529.5269-8-alex.bennee@linaro.org
State Superseded
Headers show
Series more random fixes | expand

Commit Message

Alex Bennée April 9, 2020, 9:15 p.m. UTC 
It seems on some compilers the test can pass but still give you
broken binaries.

[AJB untested - please could windows users test]

Fixes: d2cd29e30736
Fixes: https://bugs.launchpad.net/qemu/+bug/1871798
Cc: Bug 1871798 <1871798@bugs.launchpad.net>
Cc: James Le Cuirot <chewi@aura-online.co.uk>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 configure | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Howard Spoelstra April 9, 2020, 10:51 p.m. UTC | #1 
On Thu, Apr 9, 2020 at 11:18 PM Alex Bennée <alex.bennee@linaro.org> wrote:

> It seems on some compilers the test can pass but still give you

> broken binaries.

>

> [AJB untested - please could windows users test]

>

> Fixes: d2cd29e30736

> Fixes: https://bugs.launchpad.net/qemu/+bug/1871798

> Cc: Bug 1871798 <1871798@bugs.launchpad.net>

> Cc: James Le Cuirot <chewi@aura-online.co.uk>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  configure | 1 +

>  1 file changed, 1 insertion(+)

>

> diff --git a/configure b/configure

> index a207cce82bc..e9c5f630c14 100755

> --- a/configure

> +++ b/configure

> @@ -807,6 +807,7 @@ MINGW32*)

>      audio_drv_list=""

>    fi

>    supported_os="yes"

> +  pie="no"

>  ;;

>  GNU/kFreeBSD)

>    bsd="yes"

> --

> 2.20.1

>


Solves my issue! So,

Tested-by: Howard Spoelstra <hsp.cat7@gmail.com>
<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Apr 9, 2020 at 11:18 PM Alex Bennée &lt;<a href="mailto:alex.bennee@linaro.org" target="_blank">alex.bennee@linaro.org</a>&gt; wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">It seems on some compilers the test can pass but still give you<br>
broken binaries.<br>
<br>
[AJB untested - please could windows users test]<br>
<br>
Fixes: d2cd29e30736<br>
Fixes: <a href="https://bugs.launchpad.net/qemu/+bug/1871798" rel="noreferrer" target="_blank">https://bugs.launchpad.net/qemu/+bug/1871798</a><br>
Cc: Bug 1871798 &lt;<a href="mailto:1871798@bugs.launchpad.net" target="_blank">1871798@bugs.launchpad.net</a>&gt;<br>
Cc: James Le Cuirot &lt;<a href="mailto:chewi@aura-online.co.uk" target="_blank">chewi@aura-online.co.uk</a>&gt;<br>
Signed-off-by: Alex Bennée &lt;<a href="mailto:alex.bennee@linaro.org" target="_blank">alex.bennee@linaro.org</a>&gt;<br>

---<br>
 configure | 1 +<br>
 1 file changed, 1 insertion(+)<br>
<br>
diff --git a/configure b/configure<br>
index a207cce82bc..e9c5f630c14 100755<br>
--- a/configure<br>
+++ b/configure<br>
@@ -807,6 +807,7 @@ MINGW32*)<br>
     audio_drv_list=&quot;&quot;<br>
   fi<br>
   supported_os=&quot;yes&quot;<br>
+  pie=&quot;no&quot;<br>
 ;;<br>
 GNU/kFreeBSD)<br>
   bsd=&quot;yes&quot;<br>
-- <br>
2.20.1<br></blockquote><div><br></div><div>Solves my issue! So,</div><div><br></div><div>Tested-by: Howard Spoelstra &lt;<a href="mailto:hsp.cat7@gmail.com" target="_blank">hsp.cat7@gmail.com</a>&gt;<br></div></div></div>
Philippe Mathieu-Daudé April 10, 2020, 10:55 a.m. UTC | #2 
On 4/9/20 11:15 PM, Alex Bennée wrote:
> It seems on some compilers the test can pass but still give you

> broken binaries.

> 

> [AJB untested - please could windows users test]

> 

> Fixes: d2cd29e30736

> Fixes: https://bugs.launchpad.net/qemu/+bug/1871798

> Cc: Bug 1871798 <1871798@bugs.launchpad.net>

> Cc: James Le Cuirot <chewi@aura-online.co.uk>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   configure | 1 +

>   1 file changed, 1 insertion(+)

> 

> diff --git a/configure b/configure

> index a207cce82bc..e9c5f630c14 100755

> --- a/configure

> +++ b/configure

> @@ -807,6 +807,7 @@ MINGW32*)

>       audio_drv_list=""

>     fi

>     supported_os="yes"

> +  pie="no"

>   ;;

>   GNU/kFreeBSD)

>     bsd="yes"

> 


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Richard Henderson April 10, 2020, 2:42 p.m. UTC | #3 
On 4/9/20 2:15 PM, Alex Bennée wrote:
> It seems on some compilers the test can pass but still give you

> broken binaries.

> 

> [AJB untested - please could windows users test]

> 

> Fixes: d2cd29e30736

> Fixes: https://bugs.launchpad.net/qemu/+bug/1871798

> Cc: Bug 1871798 <1871798@bugs.launchpad.net>

> Cc: James Le Cuirot <chewi@aura-online.co.uk>

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>  configure | 1 +

>  1 file changed, 1 insertion(+)


Reviewed-by: Richard Henderson <richard.henderson@linaro.org>



r~
diff mbox series

Patch

diff --git a/configure b/configure
index a207cce82bc..e9c5f630c14 100755
--- a/configure
+++ b/configure
@@ -807,6 +807,7 @@  MINGW32*)
     audio_drv_list=""
   fi
   supported_os="yes"
+  pie="no"
 ;;
 GNU/kFreeBSD)
   bsd="yes"