diff mbox series

[v9,14/74] microblaze: convert to helper_cpu_halted_set

Message ID 20200521164011.638-15-robert.foley@linaro.org
State Superseded
Headers show
Series per-CPU locks | expand

Commit Message

Robert Foley May 21, 2020, 4:39 p.m. UTC 
From: "Emilio G. Cota" <cota@braap.org>


Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

Signed-off-by: Emilio G. Cota <cota@braap.org>

Signed-off-by: Robert Foley <robert.foley@linaro.org>

---
 target/microblaze/translate.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

-- 
2.17.1

Comments

Edgar E. Iglesias May 21, 2020, 4:45 p.m. UTC | #1 
On Thu, May 21, 2020 at 12:39:11PM -0400, Robert Foley wrote:
> From: "Emilio G. Cota" <cota@braap.org>

> 

> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>

> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>

> Signed-off-by: Emilio G. Cota <cota@braap.org>

> Signed-off-by: Robert Foley <robert.foley@linaro.org>



Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>



> ---

>  target/microblaze/translate.c | 4 +---

>  1 file changed, 1 insertion(+), 3 deletions(-)

> 

> diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c

> index f6ff2591c3..c08a7f1d39 100644

> --- a/target/microblaze/translate.c

> +++ b/target/microblaze/translate.c

> @@ -1237,9 +1237,7 @@ static void dec_br(DisasContext *dc)

>              LOG_DIS("sleep\n");

>  

>              t_sync_flags(dc);

> -            tcg_gen_st_i32(tmp_1, cpu_env,

> -                           -offsetof(MicroBlazeCPU, env)

> -                           +offsetof(CPUState, halted));

> +            gen_helper_cpu_halted_set(cpu_env, tmp_1);

>              tcg_gen_movi_i64(cpu_SR[SR_PC], dc->pc + 4);

>              gen_helper_raise_exception(cpu_env, tmp_hlt);

>              tcg_temp_free_i32(tmp_hlt);

> -- 

> 2.17.1

>
diff mbox series

Patch

diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c
index f6ff2591c3..c08a7f1d39 100644
--- a/target/microblaze/translate.c
+++ b/target/microblaze/translate.c
@@ -1237,9 +1237,7 @@  static void dec_br(DisasContext *dc)
             LOG_DIS("sleep\n");
 
             t_sync_flags(dc);
-            tcg_gen_st_i32(tmp_1, cpu_env,
-                           -offsetof(MicroBlazeCPU, env)
-                           +offsetof(CPUState, halted));
+            gen_helper_cpu_halted_set(cpu_env, tmp_1);
             tcg_gen_movi_i64(cpu_SR[SR_PC], dc->pc + 4);
             gen_helper_raise_exception(cpu_env, tmp_hlt);
             tcg_temp_free_i32(tmp_hlt);