diff mbox series

net: dsa: input correct header length for skb_cow_head()

Message ID 1584320645-25041-1-git-send-email-xiaofeis@codeaurora.org
State New
Headers show
Series net: dsa: input correct header length for skb_cow_head() | expand

Commit Message

xiaofeis March 16, 2020, 1:04 a.m. UTC
We need to ensure there is enough headroom to push QCA header,
so input the QCA header length instead of 0.

Signed-off-by: xiaofeis <xiaofeis@codeaurora.org>
---
 net/dsa/tag_qca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

xiaofeis March 16, 2020, 9:35 a.m. UTC | #1
在 2020-03-16 17:07,David Miller 写道:
> From: xiaofeis <xiaofeis@codeaurora.org>
> Date: Mon, 16 Mar 2020 09:04:05 +0800
> 
>> We need to ensure there is enough headroom to push QCA header,
>> so input the QCA header length instead of 0.
>> 
>> Signed-off-by: xiaofeis <xiaofeis@codeaurora.org>
> 
> This was already fixed by:
> 
> commit 04fb91243a853dbde216d829c79d9632e52aa8d9
> Author: Per Forlin <per.forlin@axis.com>
> Date:   Thu Feb 13 15:37:09 2020 +0100
> 
>     net: dsa: tag_qca: Make sure there is headroom for tag
Ok, got it.
diff mbox series

Patch

diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c
index c958852..72c1629 100644
--- a/net/dsa/tag_qca.c
+++ b/net/dsa/tag_qca.c
@@ -36,7 +36,7 @@  static struct sk_buff *qca_tag_xmit(struct sk_buff *skb, struct net_device *dev)
 	dev->stats.tx_packets++;
 	dev->stats.tx_bytes += skb->len;
 
-	if (skb_cow_head(skb, 0) < 0)
+	if (skb_cow_head(skb, QCA_HDR_LEN) < 0)
 		return NULL;
 
 	skb_push(skb, QCA_HDR_LEN);