| Message ID | 20200308055445.1992189-1-bjorn.andersson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: msm8998-mtp: Disable funnel 4 and 5 | expand |
On Sat, Mar 7, 2020 at 10:58 PM Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > Disable Coresight funnel 4 and 5, for now, as these causes the MTP to > crash when clock late_initcall disables unused clocks. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> I'm guessing that these are accessed by something else in the system, without properly putting its own vote or something. Similar to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.6-rc5&id=12eced09cd301aa7b1868a67c50a651c2aacd363 If I get some time, I'll try to repro and hopefully identify what is exactly going wrong.
diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi index 0e0b9bc12945..8a14b2bf7bca 100644 --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi @@ -95,11 +95,15 @@ &funnel3 { }; &funnel4 { - status = "okay"; + // FIXME: Figure out why clock late_initcall crashes the board with + // this enabled. + // status = "okay"; }; &funnel5 { - status = "okay"; + // FIXME: Figure out why clock late_initcall crashes the board with + // this enabled. + // status = "okay"; }; &pm8005_lsid1 {
Disable Coresight funnel 4 and 5, for now, as these causes the MTP to crash when clock late_initcall disables unused clocks. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- arch/arm64/boot/dts/qcom/msm8998-mtp.dtsi | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)