diff mbox series

[v3,28/30] gitlab: split build-disabled into two phases

Message ID 20200626181357.26211-29-alex.bennee@linaro.org
State New
Headers show
Series testing/next (gitlab, vm, docker) | expand

Commit Message

Alex Bennée June 26, 2020, 6:13 p.m. UTC
As we run check-qtest in "SLOW" mode this can timeout so split into
two jobs.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

---
 .gitlab-ci.yml | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé June 29, 2020, 10:02 a.m. UTC | #1
On 6/26/20 8:13 PM, Alex Bennée wrote:
> As we run check-qtest in "SLOW" mode this can timeout so split into

> two jobs.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>


Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>


> ---

>  .gitlab-ci.yml | 13 ++++++++++++-

>  1 file changed, 12 insertions(+), 1 deletion(-)

> 

> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml

> index eb5b335c1e9..c6f1addc2f3 100644

> --- a/.gitlab-ci.yml

> +++ b/.gitlab-ci.yml

> @@ -110,7 +110,7 @@ check:system-fedora-alt:

>      IMAGE: fedora

>      MAKE_CHECK_ARGS: check-acceptance

>  

> -build-disabled:

> +build:system-fedora-disabled:

>    <<: *native_build_job_definition

>    variables:

>      IMAGE: fedora

> @@ -121,6 +121,17 @@ build-disabled:

>        --disable-qom-cast-debug --disable-spice --disable-vhost-vsock

>        --disable-vhost-net --disable-vhost-crypto --disable-vhost-user

>      TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user

> +  artifacts:

> +    paths:

> +      - build

> +

> +qtest:system-fedora-disabled:

> +  <<: *native_test_job_definition

> +  needs:

> +    - job: build:system-fedora-disabled

> +      artifacts: true

> +  variables:

> +    IMAGE: fedora

>      MAKE_CHECK_ARGS: check-qtest SPEED=slow

>  

>  build-tcg-disabled:

>
Thomas Huth June 29, 2020, 10:58 a.m. UTC | #2
On 26/06/2020 20.13, Alex Bennée wrote:
> As we run check-qtest in "SLOW" mode this can timeout so split into

> two jobs.

> 

> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

> ---

>   .gitlab-ci.yml | 13 ++++++++++++-

>   1 file changed, 12 insertions(+), 1 deletion(-)

> 

> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml

> index eb5b335c1e9..c6f1addc2f3 100644

> --- a/.gitlab-ci.yml

> +++ b/.gitlab-ci.yml

> @@ -110,7 +110,7 @@ check:system-fedora-alt:

>       IMAGE: fedora

>       MAKE_CHECK_ARGS: check-acceptance

>   

> -build-disabled:

> +build:system-fedora-disabled:

>     <<: *native_build_job_definition

>     variables:

>       IMAGE: fedora

> @@ -121,6 +121,17 @@ build-disabled:

>         --disable-qom-cast-debug --disable-spice --disable-vhost-vsock

>         --disable-vhost-net --disable-vhost-crypto --disable-vhost-user

>       TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user

> +  artifacts:

> +    paths:

> +      - build

> +

> +qtest:system-fedora-disabled:

> +  <<: *native_test_job_definition

> +  needs:

> +    - job: build:system-fedora-disabled

> +      artifacts: true

> +  variables:

> +    IMAGE: fedora

>       MAKE_CHECK_ARGS: check-qtest SPEED=slow


Reviewed-by: Thomas Huth <thuth@redhat.com>


I still wonder why the test got slower in the recent weeks ... and maybe 
we should also change the target list now that the test runs in a 
separate stage? ... well, I guess that's also something for later ...

  Thomas
Alex Bennée June 29, 2020, 12:57 p.m. UTC | #3
Thomas Huth <thuth@redhat.com> writes:

> On 26/06/2020 20.13, Alex Bennée wrote:

>> As we run check-qtest in "SLOW" mode this can timeout so split into

>> two jobs.

>> 

>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

>> ---

>>   .gitlab-ci.yml | 13 ++++++++++++-

>>   1 file changed, 12 insertions(+), 1 deletion(-)

>> 

>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml

>> index eb5b335c1e9..c6f1addc2f3 100644

>> --- a/.gitlab-ci.yml

>> +++ b/.gitlab-ci.yml

>> @@ -110,7 +110,7 @@ check:system-fedora-alt:

>>       IMAGE: fedora

>>       MAKE_CHECK_ARGS: check-acceptance

>>   

>> -build-disabled:

>> +build:system-fedora-disabled:

>>     <<: *native_build_job_definition

>>     variables:

>>       IMAGE: fedora

>> @@ -121,6 +121,17 @@ build-disabled:

>>         --disable-qom-cast-debug --disable-spice --disable-vhost-vsock

>>         --disable-vhost-net --disable-vhost-crypto --disable-vhost-user

>>       TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user

>> +  artifacts:

>> +    paths:

>> +      - build

>> +

>> +qtest:system-fedora-disabled:

>> +  <<: *native_test_job_definition

>> +  needs:

>> +    - job: build:system-fedora-disabled

>> +      artifacts: true

>> +  variables:

>> +    IMAGE: fedora

>>       MAKE_CHECK_ARGS: check-qtest SPEED=slow

>

> Reviewed-by: Thomas Huth <thuth@redhat.com>

>

> I still wonder why the test got slower in the recent weeks ... and maybe 

> we should also change the target list now that the test runs in a 

> separate stage? ... well, I guess that's also something for later ...


s390x acceptance tests seem to be running a lot slower than they did on
Travis. I can't believe it's just a difference in core speed of the VM.


-- 
Alex Bennée
diff mbox series

Patch

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index eb5b335c1e9..c6f1addc2f3 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -110,7 +110,7 @@  check:system-fedora-alt:
     IMAGE: fedora
     MAKE_CHECK_ARGS: check-acceptance
 
-build-disabled:
+build:system-fedora-disabled:
   <<: *native_build_job_definition
   variables:
     IMAGE: fedora
@@ -121,6 +121,17 @@  build-disabled:
       --disable-qom-cast-debug --disable-spice --disable-vhost-vsock
       --disable-vhost-net --disable-vhost-crypto --disable-vhost-user
     TARGETS: i386-softmmu ppc64-softmmu mips64-softmmu i386-linux-user
+  artifacts:
+    paths:
+      - build
+
+qtest:system-fedora-disabled:
+  <<: *native_test_job_definition
+  needs:
+    - job: build:system-fedora-disabled
+      artifacts: true
+  variables:
+    IMAGE: fedora
     MAKE_CHECK_ARGS: check-qtest SPEED=slow
 
 build-tcg-disabled: