From patchwork Tue Jun 30 13:33:04 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Elder X-Patchwork-Id: 192081 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp3822121ilg; Tue, 30 Jun 2020 06:33:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxiL3uiGiPHqP43AqHV/2gdmCrAT5O3bAGJ9pCSRlBepEf4A99I6j7a1VRUH89aXzBe+tWg X-Received: by 2002:a17:906:a892:: with SMTP id ha18mr18645387ejb.462.1593524024596; Tue, 30 Jun 2020 06:33:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593524024; cv=none; d=google.com; s=arc-20160816; b=VSwIw1s09SbJcrsaWFb43U3x9szUiqLgnW1CpwFtrlZP1AttY4y07msLtCTeRFD50y Sx/cLvq6w257rKxt2p5QNgDGn4mm019YORT+AbBv92OcIR6qB73norDjRHfnkAdhZw5I /Im84s2FAR+q+8CMTuamHuBgLcyZSP3ywAwxEbCUNkX9WXZiHYf9v0aYXzTspIc7PpVx PgQtl7MBClQTT65Q3bmGQtOU0flbP9PpJ6/ae/VwFfbfg+BQ7pRaIeYiWNGZNZn3RDy3 cuoUJMxKlmteXeCrj52rSCNaYr3Le4834CwmttMfSUdUs/EquKawO1u6Kh82tbtWyUe4 5neA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=NLGLXbQMNnc8WjfyUZyG3CP5YRJLw4TctWKcG9p/1fY=; b=up1h/QmCXswfu4kj89P/wX416CVpabrJkIpYAqUWnsMrObVvrtCWFzsnOmhwcUs8cd eERd7b1c/j0bjVLUSYRV9h+lDR7TvGLJ8hc7X0e35JO3Ok9SEuEmz6ZzlG/hT1Nb6Phz r2QdhfpAYFM+LjvzvbFeliGHivI4Qp0n/JpCgUmf3pBJKspat7cnQQTBUTWUWKgVBLEr 54aGhX440DLJPv4adrjqh87wf4LhUYzAVG5wkpI9YSK3tNWqFAvlPFobBMo1eKGSOBGd 9AEM4SC7XfZ0c1Tu2+jXCvczfSE9FTHeQYOBBCS7Qc0vDAe8yeo8fvwYJwdpCCaIT6FZ q5kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Og34JDlm; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s18si1679440edx.6.2020.06.30.06.33.44; Tue, 30 Jun 2020 06:33:44 -0700 (PDT) Received-SPF: pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Og34JDlm; spf=pass (google.com: domain of netdev-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=netdev-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387860AbgF3Nd1 (ORCPT + 9 others); Tue, 30 Jun 2020 09:33:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44846 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732971AbgF3NdO (ORCPT ); Tue, 30 Jun 2020 09:33:14 -0400 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4158C08C5DB for ; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) Received: by mail-il1-x142.google.com with SMTP id k1so16541463ils.2 for ; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=NLGLXbQMNnc8WjfyUZyG3CP5YRJLw4TctWKcG9p/1fY=; b=Og34JDlmtuj4ZWyd3kF6svBJGNitRgk6p5FKsa/nN75Ah9a3Es3O+eZM45muel+Rhk dleUbXgNYLtuEu1EZhtXgIohsx1jZkZShfZo42mG8DCqJhU0xFQzto/2o+ZbGDXBYHk1 AVqPGWNnIHeMOhdemIMtMrRAXGDaH4D8dUUd5TjvCS7pKPEAzsYqIU7pmeIY2sOJBMiP BgejmR7zkKReFMxWg7zwE03VaaPK2SW/Pl9iKISDjDuGn+lGXm4YjDOgjSR7FHVGVEo7 1b+HDCEPXjfzWLI+SyDHcekCsXTeFmOi6fKfP6gQfm6Yi2Z7JLZcbSBhGUR+xTlTiEZI Bkxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=NLGLXbQMNnc8WjfyUZyG3CP5YRJLw4TctWKcG9p/1fY=; b=fBLh58K7vWqHLlk10r0RSe2rcXvfPaNa8sjKNJLvikj+nwlceOBUlMy5pUpviob3D+ z+LDyCoy/h8PeDISJvziD3299m7aZOGj1+O7iawVwjb0pORS2tMOvefuQOoijexEdRAv fuiJlqG6SUW0CZHUHjnhW2R7kV6lKv6nEDNmPl3zuPt6HADkS9OUFrV8sDbTBfHsGHXv Vv9ToXyKRXqAK6jiEel2fFY4JPIylcWbTzXCviW9PVsYDx9hXJ8O1KRcCAk26quci015 rfiaNXTZ85Sv+oDPhIK8xAMPIWlYh0PcMxEN9Iz0zxRA6YhAtJzM8DtxzHpno1lo/eBv erlg== X-Gm-Message-State: AOAM531F/BqbLimhxS909RpLOqR2iScibDuRpllqgY6tGp1wRHEMm/HT haIYjlftGDQbzLZbUSLVZgUu2g== X-Received: by 2002:a92:9f0e:: with SMTP id u14mr2460094ili.277.1593523993143; Tue, 30 Jun 2020 06:33:13 -0700 (PDT) Received: from presto.localdomain (c-73-185-129-58.hsd1.mn.comcast.net. [73.185.129.58]) by smtp.gmail.com with ESMTPSA id u15sm1538776iog.18.2020.06.30.06.33.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jun 2020 06:33:12 -0700 (PDT) From: Alex Elder To: davem@davemloft.net, kuba@kernel.org Cc: evgreen@chromium.org, subashab@codeaurora.org, cpratapa@codeaurora.org, bjorn.andersson@linaro.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v2 5/5] net: ipa: HOL_BLOCK_EN_FMASK is a 1-bit mask Date: Tue, 30 Jun 2020 08:33:04 -0500 Message-Id: <20200630133304.1331058-6-elder@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200630133304.1331058-1-elder@linaro.org> References: <20200630133304.1331058-1-elder@linaro.org> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The convention throughout the IPA driver is to directly use single-bit field mask values, rather than using (for example) u32_encode_bits() to set or clear them. Fix the one place that doesn't follow that convention, which sets HOL_BLOCK_EN_FMASK in ipa_endpoint_init_hol_block_enable(). Signed-off-by: Alex Elder --- v2: No change from version 1. drivers/net/ipa/ipa_endpoint.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 566ff6a09e65..0332dcbcaaae 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -671,7 +671,7 @@ ipa_endpoint_init_hol_block_enable(struct ipa_endpoint *endpoint, bool enable) u32 offset; u32 val; - val = u32_encode_bits(enable ? 1 : 0, HOL_BLOCK_EN_FMASK); + val = enable ? HOL_BLOCK_EN_FMASK : 0; offset = IPA_REG_ENDP_INIT_HOL_BLOCK_EN_N_OFFSET(endpoint_id); iowrite32(val, endpoint->ipa->reg_virt + offset); }