From patchwork Wed Aug 21 08:46:15 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hanjun Guo X-Patchwork-Id: 19361 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-vc0-f197.google.com (mail-vc0-f197.google.com [209.85.220.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A63F2248E6 for ; Wed, 21 Aug 2013 08:50:50 +0000 (UTC) Received: by mail-vc0-f197.google.com with SMTP id ha11sf106857vcb.8 for ; Wed, 21 Aug 2013 01:50:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-gm-message-state:delivered-to:from:to:cc:subject :date:message-id:x-original-sender:x-original-authentication-results :precedence:mailing-list:list-id:list-post:list-help:list-archive :list-unsubscribe; bh=bI0gCGCf/EurpR6UMjSLwndD6ko/c/XkIgS8z36155A=; b=OBCIMkpNOP4zAaq979FgN/xKpjPq3NPFMMCNxX8qmCUvBiZgGLnmAAc20NqOirV/7J XSb9jv7SkenwPZ3MCa13Ze0oqPJXz55llx000HN5mfW7MxBBs+hfTfZuRczusKtV5LpG Yxy7zU6+xKFl1nt3mW9mafpr3FJeo4G6Q4RkS40yCUPi2QoLGQu/cMVNxRbGi5KI9PHM Tra6EcKZYc25gjmlgZ2yxsh5TjpgNXhXSQn9QSA4QAv4jgVu1C/Z6nr+Ok+S1SQSEktR Em8Pm1cutfdxxy6pZ4Q2lUlUgo44YxBhurEFEzN1Ek+DvXQJbzyaRsWGaqFnnA5hjGY7 TJSA== X-Received: by 10.236.2.5 with SMTP id 5mr2249257yhe.23.1377075050094; Wed, 21 Aug 2013 01:50:50 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.39.165 with SMTP id q5ls593343qek.22.gmail; Wed, 21 Aug 2013 01:50:50 -0700 (PDT) X-Received: by 10.52.76.38 with SMTP id h6mr4428196vdw.10.1377075049976; Wed, 21 Aug 2013 01:50:49 -0700 (PDT) Received: from mail-ve0-f181.google.com (mail-ve0-f181.google.com [209.85.128.181]) by mx.google.com with ESMTPS id aj7si1804062vec.21.1969.12.31.16.00.00 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Aug 2013 01:50:49 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.181; Received: by mail-ve0-f181.google.com with SMTP id jz10so93573veb.26 for ; Wed, 21 Aug 2013 01:50:49 -0700 (PDT) X-Gm-Message-State: ALoCoQl7evqu9vIbLiWAb5AjA0+4pzLCsmj8usmtFKWSzZ9llCTYf3B+1yF6wgAisKdaaL+fKz/g X-Received: by 10.220.16.73 with SMTP id n9mr966705vca.24.1377075049817; Wed, 21 Aug 2013 01:50:49 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.174.196 with SMTP id u4csp206960vcz; Wed, 21 Aug 2013 01:50:49 -0700 (PDT) X-Received: by 10.68.160.5 with SMTP id xg5mr6523270pbb.173.1377075048848; Wed, 21 Aug 2013 01:50:48 -0700 (PDT) Received: from hanjun-Latitude-D630 ([218.17.215.175]) by mx.google.com with ESMTPS id dz4si4418095pbc.269.1969.12.31.16.00.00 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 21 Aug 2013 01:50:48 -0700 (PDT) Received-SPF: neutral (google.com: 218.17.215.175 is neither permitted nor denied by best guess record for domain of hanjun@hanjun-latitude-d630) client-ip=218.17.215.175; Received: from hanjun-Latitude-D630 (localhost [127.0.0.1]) by hanjun-Latitude-D630 (8.14.4/8.14.4/Debian-2ubuntu2) with ESMTP id r7L8lbHZ010682; Wed, 21 Aug 2013 16:47:37 +0800 Received: (from hanjun@localhost) by hanjun-Latitude-D630 (8.14.4/8.14.4/Submit) id r7L8lW5v010676; Wed, 21 Aug 2013 16:47:32 +0800 From: Hanjun Guo To: "Rafael J. Wysocki" , Thomas Gleixner Cc: Ingo Molnar , x86@kernel.org, linux-pm@vger.kernel.org, patches@linaro.org, linaro-kernel@lists.linaro.org, linaro-acpi@lists.linaro.org, Hanjun Guo Subject: [PATCH 1/3] x86 / ACPI: modify the stale comment for __acpi_map_table() Date: Wed, 21 Aug 2013 16:46:15 +0800 Message-Id: <1377074777-10639-1-git-send-email-hanjun.guo@linaro.org> X-Mailer: git-send-email 1.7.9.5 X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: hanjun.guo@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.181 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The comment for __acpi_map_table() is obvious wrong. In fact, after commit 1c14fa49 (x86: use early_ioremap in __acpi_map_table), the comment became stale, so remove it and add a new one. Signed-off-by: Hanjun Guo --- arch/x86/kernel/acpi/boot.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c index 2627a81..665f857 100644 --- a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@ -141,16 +141,8 @@ static u32 irq_to_gsi(int irq) } /* - * Temporarily use the virtual area starting from FIX_IO_APIC_BASE_END, - * to map the target physical address. The problem is that set_fixmap() - * provides a single page, and it is possible that the page is not - * sufficient. - * By using this area, we can map up to MAX_IO_APICS pages temporarily, - * i.e. until the next __va_range() call. - * - * Important Safety Note: The fixed I/O APIC page numbers are *subtracted* - * from the fixed base. That's why we start at FIX_IO_APIC_BASE_END and - * count idx down while incrementing the phys address. + * __acpi_map_table() will be called before the memory allocation + * is ready, so call early_ioremap() to map tables. */ char *__init __acpi_map_table(unsigned long phys, unsigned long size) {