| Message ID | 1377701263-3319-25-git-send-email-julien.grall@linaro.org |
|---|---|
| State | Superseded, archived |
| Headers | show |
On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote: > On Versatile there are a bunch of devices which must not be pass-through to any > guest (power management and cache coherency devices). > > This commit also blacklist the HDLCD device because then is unable to correctly ^s "then ____ is unable" ? Missing word? "Linux" or "dom0" maybe? Or maybe s/then/dom0/? Is this a consequence of our HDLCD driver or just of lack of memreserve? > map the framebuffer. Therefore, when Linux will try to access to the framebuffer, > Xen will receive a non-handled data access. > > Signed-off-by: Julien Grall <julien.grall@linaro.org> > > --- > Changes in v2: > - Fix typoes in commit message > --- > xen/arch/arm/platforms/vexpress.c | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/xen/arch/arm/platforms/vexpress.c b/xen/arch/arm/platforms/vexpress.c > index 6f7dc2c..298c141 100644 > --- a/xen/arch/arm/platforms/vexpress.c > +++ b/xen/arch/arm/platforms/vexpress.c > @@ -125,9 +125,26 @@ static const char * const vexpress_dt_compat[] __initdata = > NULL > }; > > +static const struct dt_device_match vexpress_blacklist_dev[] __initconst = > +{ > + /* Cache Coherent Interconnect */ > + DT_MATCH_COMPATIBLE("arm,cci-400"), > + DT_MATCH_COMPATIBLE("arm,cci-400-pmu"), > + /* Video device > + * TODO: remove it once memreserve is handled properly by Xen > + */ > + DT_MATCH_COMPATIBLE("arm,hdlcd"), > + /* Hardware power management */ > + DT_MATCH_COMPATIBLE("arm,vexpress-reset"), > + DT_MATCH_COMPATIBLE("arm,vexpress-reboot"), > + DT_MATCH_COMPATIBLE("arm,vexpress-shutdown"), > + { /* sentinel */ }, > +}; > + > PLATFORM_START(vexpress, "VERSATILE EXPRESS") > .compatible = vexpress_dt_compat, > .reset = vexpress_reset, > + .blacklist_dev = vexpress_blacklist_dev, > PLATFORM_END > > /*
On 09/09/2013 12:54 PM, Ian Campbell wrote: > On Wed, 2013-08-28 at 15:47 +0100, Julien Grall wrote: >> On Versatile there are a bunch of devices which must not be pass-through to any >> guest (power management and cache coherency devices). >> >> This commit also blacklist the HDLCD device because then is unable to correctly > ^s > > "then ____ is unable" ? Missing word? "Linux" or "dom0" maybe? Or maybe > s/then/dom0/? Xen. I updated the commit message. > Is this a consequence of our HDLCD driver or just of lack of memreserve? It's a lack of memreserve. > >> map the framebuffer. Therefore, when Linux will try to access to the framebuffer, >> Xen will receive a non-handled data access. >> >> Signed-off-by: Julien Grall <julien.grall@linaro.org> >> >> --- >> Changes in v2: >> - Fix typoes in commit message >> --- >> xen/arch/arm/platforms/vexpress.c | 17 +++++++++++++++++ >> 1 file changed, 17 insertions(+) >> >> diff --git a/xen/arch/arm/platforms/vexpress.c b/xen/arch/arm/platforms/vexpress.c >> index 6f7dc2c..298c141 100644 >> --- a/xen/arch/arm/platforms/vexpress.c >> +++ b/xen/arch/arm/platforms/vexpress.c >> @@ -125,9 +125,26 @@ static const char * const vexpress_dt_compat[] __initdata = >> NULL >> }; >> >> +static const struct dt_device_match vexpress_blacklist_dev[] __initconst = >> +{ >> + /* Cache Coherent Interconnect */ >> + DT_MATCH_COMPATIBLE("arm,cci-400"), >> + DT_MATCH_COMPATIBLE("arm,cci-400-pmu"), >> + /* Video device >> + * TODO: remove it once memreserve is handled properly by Xen >> + */ >> + DT_MATCH_COMPATIBLE("arm,hdlcd"), >> + /* Hardware power management */ >> + DT_MATCH_COMPATIBLE("arm,vexpress-reset"), >> + DT_MATCH_COMPATIBLE("arm,vexpress-reboot"), >> + DT_MATCH_COMPATIBLE("arm,vexpress-shutdown"), >> + { /* sentinel */ }, >> +}; >> + >> PLATFORM_START(vexpress, "VERSATILE EXPRESS") >> .compatible = vexpress_dt_compat, >> .reset = vexpress_reset, >> + .blacklist_dev = vexpress_blacklist_dev, >> PLATFORM_END >> >> /* > >
diff --git a/xen/arch/arm/platforms/vexpress.c b/xen/arch/arm/platforms/vexpress.c index 6f7dc2c..298c141 100644 --- a/xen/arch/arm/platforms/vexpress.c +++ b/xen/arch/arm/platforms/vexpress.c @@ -125,9 +125,26 @@ static const char * const vexpress_dt_compat[] __initdata = NULL }; +static const struct dt_device_match vexpress_blacklist_dev[] __initconst = +{ + /* Cache Coherent Interconnect */ + DT_MATCH_COMPATIBLE("arm,cci-400"), + DT_MATCH_COMPATIBLE("arm,cci-400-pmu"), + /* Video device + * TODO: remove it once memreserve is handled properly by Xen + */ + DT_MATCH_COMPATIBLE("arm,hdlcd"), + /* Hardware power management */ + DT_MATCH_COMPATIBLE("arm,vexpress-reset"), + DT_MATCH_COMPATIBLE("arm,vexpress-reboot"), + DT_MATCH_COMPATIBLE("arm,vexpress-shutdown"), + { /* sentinel */ }, +}; + PLATFORM_START(vexpress, "VERSATILE EXPRESS") .compatible = vexpress_dt_compat, .reset = vexpress_reset, + .blacklist_dev = vexpress_blacklist_dev, PLATFORM_END /*
On Versatile there are a bunch of devices which must not be pass-through to any guest (power management and cache coherency devices). This commit also blacklist the HDLCD device because then is unable to correctly map the framebuffer. Therefore, when Linux will try to access to the framebuffer, Xen will receive a non-handled data access. Signed-off-by: Julien Grall <julien.grall@linaro.org> --- Changes in v2: - Fix typoes in commit message --- xen/arch/arm/platforms/vexpress.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)