| Message ID | 22f0d94203b9e3d29f123c0e80df4b012e01dbb5.1378963070.git.viresh.kumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 09/12/2013 10:55 AM, Viresh Kumar wrote: > We don't need a blank line just at start of a block, lets remove it. > Well, I felt having that line avoids clutter, especially since the code around it was already a bit hard to read.. Anyway, I don't have any strong opinions either way. So no objections from my side. (But you might have to rebase this patch on top of Rafael's tree, due to the recent changes he pushed in to this code). Regards, Srivatsa S. Bhat > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> > --- > drivers/cpufreq/cpufreq.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > index 5a64f66..28477eb 100644 > --- a/drivers/cpufreq/cpufreq.c > +++ b/drivers/cpufreq/cpufreq.c > @@ -1185,7 +1185,6 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, > if (cpu != policy->cpu && !frozen) { > sysfs_remove_link(&dev->kobj, "cpufreq"); > } else if (cpus > 1) { > - > new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu, frozen); > if (new_cpu >= 0) { > WARN_ON(lock_policy_rwsem_write(cpu)); >
On 12 September 2013 13:46, Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com> wrote: > Well, I felt having that line avoids clutter, especially since the code > around it was already a bit hard to read.. Well, its exact opposite for me.. somehow my attending keeps dragging to extra blank lines :) > Anyway, I don't have any strong opinions either way. So no objections > from my side. (But you might have to rebase this patch on top of Rafael's > tree, due to the recent changes he pushed in to this code). I tried a rebase and couldn't find a issue.. And so not resending the series.
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 5a64f66..28477eb 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1185,7 +1185,6 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, if (cpu != policy->cpu && !frozen) { sysfs_remove_link(&dev->kobj, "cpufreq"); } else if (cpus > 1) { - new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu, frozen); if (new_cpu >= 0) { WARN_ON(lock_policy_rwsem_write(cpu));
We don't need a blank line just at start of a block, lets remove it. Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/cpufreq.c | 1 - 1 file changed, 1 deletion(-)