| Message ID | 20200113180720.77461-1-jernej.skrabec@siol.net |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: allwinner: h6: tanix-tx6: Use internal oscillator | expand |
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts index 83e6cb0e59ce..af3aebda47bb 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts @@ -91,6 +91,12 @@ &r_ir { status = "okay"; }; +/* This board doesn't have external 32 kHz crystal. */ +&rtc { + assigned-clocks = <&rtc 0>; + assigned-clock-parents = <&rtc 2>; +}; + &uart0 { pinctrl-names = "default"; pinctrl-0 = <&uart0_ph_pins>;
Tanix TX6 doesn't have external 32 kHz oscillator, so switch RTC clock to internal one. Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net> --- While this patch gives one possible solution, I mainly want to start discussion why Allwinner SoC dtsi reference external 32 kHz crystal although some boards don't have it. My proposal would be to make clock property optional, based on the fact if external crystal is present or not. However, I'm not sure if that is possible at this point or not. Driver also considers missing clock property as deprecated (old DT) [1], so this might complicate things even further. What do you think? Best regards, Jernej [1] https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-sun6i.c#L263 arch/arm64/boot/dts/allwinner/sun50i-h6-tanix-tx6.dts | 6 ++++++ 1 file changed, 6 insertions(+)