| Message ID | 20200228154142.13860-1-ckeepax@opensource.cirrus.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: core: Remove extra kref_get which blocks hogs being freed | expand |
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 446d84fe0e31c..f23c55e221955 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -2021,7 +2021,6 @@ static int pinctrl_claim_hogs(struct pinctrl_dev *pctldev) return PTR_ERR(pctldev->p); } - kref_get(&pctldev->p->users); pctldev->hog_default = pinctrl_lookup_state(pctldev->p, PINCTRL_STATE_DEFAULT); if (IS_ERR(pctldev->hog_default)) {
kref_init starts with the reference count at 1, which will be balanced by the pinctrl_put in pinctrl_unregister. The additional kref_get in pinctrl_claim_hogs will increase this count to 2 and cause the hogs to not get freed when pinctrl_unregister is called. Fixes: 6118714275f0 ("pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()") Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com> --- drivers/pinctrl/core.c | 1 - 1 file changed, 1 deletion(-)