diff mbox series

[v2] i2c: cadence: Add an error handling for platform_get_irq()

Message ID 20200520144821.8069-1-zhengdejin5@gmail.com
State Superseded
Headers show
Series [v2] i2c: cadence: Add an error handling for platform_get_irq() | expand

Commit Message

Dejin Zheng May 20, 2020, 2:48 p.m. UTC 
The driver initialization should be end immediately after found
the platform_get_irq() function return an error.

Fixes: df8eb5691c48d3b0 ("i2c: Add driver for Cadence I2C controller")
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
v1 -> v2:
	- add Fixes tag.

 drivers/i2c/busses/i2c-cadence.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
index 89d58f7d2a25..0e8debe32cea 100644
--- a/drivers/i2c/busses/i2c-cadence.c
+++ b/drivers/i2c/busses/i2c-cadence.c
@@ -912,6 +912,8 @@  static int cdns_i2c_probe(struct platform_device *pdev)
 		return PTR_ERR(id->membase);
 
 	id->irq = platform_get_irq(pdev, 0);
+	if (id->irq < 0)
+		return id->irq;
 
 	id->adap.owner = THIS_MODULE;
 	id->adap.dev.of_node = pdev->dev.of_node;