diff mbox series

input: rmi4: rmi_spi: Use new structure for SPI transfer delays

Message ID 20200227130336.27042-1-sergiu.cuciurean@analog.com
State Accepted
Commit 9db5fbe1a4968fcd0fae4d10565abccb9579a553
Headers show
Series input: rmi4: rmi_spi: Use new structure for SPI transfer delays | expand

Commit Message

Sergiu Cuciurean Feb. 27, 2020, 1:03 p.m. UTC
In a recent change to the SPI subsystem [1], a new `delay` struct was added
to replace the `delay_usecs`. This change replaces the current
`delay_usecs` with `delay` for this driver.

The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure
that both `delay_usecs` & `delay` are used (in this order to preserve
backwards compatibility).

[1] commit bebcfd272df6 ("spi: introduce `delay` field for
`spi_transfer` + spi_transfer_delay_exec()")

Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>
---
 drivers/input/rmi4/rmi_spi.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

Comments

Dmitry Torokhov Dec. 11, 2020, 5:57 a.m. UTC | #1
On Thu, Feb 27, 2020 at 03:03:36PM +0200, Sergiu Cuciurean wrote:
> In a recent change to the SPI subsystem [1], a new `delay` struct was added

> to replace the `delay_usecs`. This change replaces the current

> `delay_usecs` with `delay` for this driver.

> 

> The `spi_transfer_delay_exec()` function [in the SPI framework] makes sure

> that both `delay_usecs` & `delay` are used (in this order to preserve

> backwards compatibility).

> 

> [1] commit bebcfd272df6 ("spi: introduce `delay` field for

> `spi_transfer` + spi_transfer_delay_exec()")

> 

> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@analog.com>


Applied, thank you.

-- 
Dmitry
diff mbox series

Patch

diff --git a/drivers/input/rmi4/rmi_spi.c b/drivers/input/rmi4/rmi_spi.c
index 27b68dc79b18..c82edda66b23 100644
--- a/drivers/input/rmi4/rmi_spi.c
+++ b/drivers/input/rmi4/rmi_spi.c
@@ -188,7 +188,8 @@  static int rmi_spi_xfer(struct rmi_spi_xport *rmi_spi,
 			memset(xfer, 0,	sizeof(struct spi_transfer));
 			xfer->tx_buf = &rmi_spi->tx_buf[i];
 			xfer->len = 1;
-			xfer->delay_usecs = spi_data->write_delay_us;
+			xfer->delay.value = spi_data->write_delay_us;
+			xfer->delay.unit = SPI_DELAY_UNIT_USECS;
 			spi_message_add_tail(xfer, &msg);
 		}
 	} else {
@@ -210,7 +211,8 @@  static int rmi_spi_xfer(struct rmi_spi_xport *rmi_spi,
 				memset(xfer, 0, sizeof(struct spi_transfer));
 				xfer->rx_buf = &rmi_spi->rx_buf[i];
 				xfer->len = 1;
-				xfer->delay_usecs = spi_data->read_delay_us;
+				xfer->delay.value = spi_data->read_delay_us;
+				xfer->delay.unit = SPI_DELAY_UNIT_USECS;
 				spi_message_add_tail(xfer, &msg);
 			}
 		} else {