| Message ID | 1381240151-15060-2-git-send-email-pranavkumar@linaro.org |
|---|---|
| State | New |
| Headers | show |
On 10/08/2013 09:49 AM, Pranavkumar Sawargaonkar wrote: > Adding AArch64(ARMv8 64bit) to the current list of valid architectures. > > For now, AArch64 name would imply AArch64 LE mode only. In future, > we might have separate names for AArch64 LE and BE. > > Signed-off-by: Anup Patel <anup.patel@linaro.org> > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > --- > src/util/virarch.c | 1 + > src/util/virarch.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/util/virarch.c b/src/util/virarch.c > index 694eba1..9e88c68 100644 > --- a/src/util/virarch.c > +++ b/src/util/virarch.c > @@ -38,6 +38,7 @@ static const struct virArchData { > { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, > + { "aarch64", 64, VIR_ARCH_LITTLE_ENDIAN }, > > { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "i686", 32, VIR_ARCH_LITTLE_ENDIAN }, > diff --git a/src/util/virarch.h b/src/util/virarch.h > index 3530f7c..d0bf9d9 100644 > --- a/src/util/virarch.h > +++ b/src/util/virarch.h > @@ -30,6 +30,7 @@ typedef enum { > VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ > VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ > VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ > + VIR_ARCH_AARCH64, /* ARMv8 64 LE http://en.wikipedia.org/wiki/ARM_architecture */ > > VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ > VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */ > ACK - Cole
On Tue, Oct 08, 2013 at 07:19:06PM +0530, Pranavkumar Sawargaonkar wrote: > Adding AArch64(ARMv8 64bit) to the current list of valid architectures. > > For now, AArch64 name would imply AArch64 LE mode only. In future, > we might have separate names for AArch64 LE and BE. Presumably the kernel has fixed 'aarch64' as always referring to LE and would add a variant like 'aarch64b' for BE mode if that was ever supported ? > Signed-off-by: Anup Patel <anup.patel@linaro.org> > Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> > --- > src/util/virarch.c | 1 + > src/util/virarch.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/src/util/virarch.c b/src/util/virarch.c > index 694eba1..9e88c68 100644 > --- a/src/util/virarch.c > +++ b/src/util/virarch.c > @@ -38,6 +38,7 @@ static const struct virArchData { > { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, > + { "aarch64", 64, VIR_ARCH_LITTLE_ENDIAN }, > > { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, > { "i686", 32, VIR_ARCH_LITTLE_ENDIAN }, > diff --git a/src/util/virarch.h b/src/util/virarch.h > index 3530f7c..d0bf9d9 100644 > --- a/src/util/virarch.h > +++ b/src/util/virarch.h > @@ -30,6 +30,7 @@ typedef enum { > VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ > VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ > VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ > + VIR_ARCH_AARCH64, /* ARMv8 64 LE http://en.wikipedia.org/wiki/ARM_architecture */ > > VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ > VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */ ACK Daniel
Hi Daniel, On 9 October 2013 20:14, Daniel P. Berrange <berrange@redhat.com> wrote: > On Tue, Oct 08, 2013 at 07:19:06PM +0530, Pranavkumar Sawargaonkar wrote: >> Adding AArch64(ARMv8 64bit) to the current list of valid architectures. >> >> For now, AArch64 name would imply AArch64 LE mode only. In future, >> we might have separate names for AArch64 LE and BE. > > Presumably the kernel has fixed 'aarch64' as always referring > to LE and would add a variant like 'aarch64b' for BE mode if > that was ever supported ? Firstly thanks for Acking my patches. Yes linux currently uses aarch64 for LE . There is a BE port going on and should add a variant similar to what you have mentioned to distinguish. > >> Signed-off-by: Anup Patel <anup.patel@linaro.org> >> Signed-off-by: Pranavkumar Sawargaonkar <pranavkumar@linaro.org> >> --- >> src/util/virarch.c | 1 + >> src/util/virarch.h | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/src/util/virarch.c b/src/util/virarch.c >> index 694eba1..9e88c68 100644 >> --- a/src/util/virarch.c >> +++ b/src/util/virarch.c >> @@ -38,6 +38,7 @@ static const struct virArchData { >> { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, >> { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, >> { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, >> + { "aarch64", 64, VIR_ARCH_LITTLE_ENDIAN }, >> >> { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, >> { "i686", 32, VIR_ARCH_LITTLE_ENDIAN }, >> diff --git a/src/util/virarch.h b/src/util/virarch.h >> index 3530f7c..d0bf9d9 100644 >> --- a/src/util/virarch.h >> +++ b/src/util/virarch.h >> @@ -30,6 +30,7 @@ typedef enum { >> VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ >> VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ >> VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ >> + VIR_ARCH_AARCH64, /* ARMv8 64 LE http://en.wikipedia.org/wiki/ARM_architecture */ >> >> VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ >> VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */ > > ACK > > > Daniel > -- > |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| > |: http://libvirt.org -o- http://virt-manager.org :| > |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| > |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :| > > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list Thanks, Pranav
diff --git a/src/util/virarch.c b/src/util/virarch.c index 694eba1..9e88c68 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -38,6 +38,7 @@ static const struct virArchData { { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, + { "aarch64", 64, VIR_ARCH_LITTLE_ENDIAN }, { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, { "i686", 32, VIR_ARCH_LITTLE_ENDIAN }, diff --git a/src/util/virarch.h b/src/util/virarch.h index 3530f7c..d0bf9d9 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -30,6 +30,7 @@ typedef enum { VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ + VIR_ARCH_AARCH64, /* ARMv8 64 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */