| Message ID | 1382122203-16057-1-git-send-email-markus.mayer@linaro.org |
|---|---|
| State | Accepted |
| Commit | 23b4faa9a36257e75dade0f2945bc3e487e6f463 |
| Headers | show |
On Fri, Oct 18, 2013 at 8:50 PM, Markus Mayer <markus.mayer@linaro.org> wrote: > The physical address of the GPIO memory address is already printed > implicitly by dev_info() as part of the device name. The virtual > address doesn't add any value. In addition, printing a resource_size_t > with %x lead to a compiler warning on some platforms. > > Signed-off-by: Markus Mayer <markus.mayer@linaro.org> Patch applied. Thanks for a quick action Markus! Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-bcm-kona.c b/drivers/gpio/gpio-bcm-kona.c index 58188ba..b3d0f81 100644 --- a/drivers/gpio/gpio-bcm-kona.c +++ b/drivers/gpio/gpio-bcm-kona.c @@ -587,8 +587,7 @@ static int bcm_kona_gpio_probe(struct platform_device *pdev) } } - dev_info(&pdev->dev, "Setting up Kona GPIO at 0x%p (phys %#x)\n", - kona_gpio->reg_base, res->start); + dev_info(&pdev->dev, "Setting up Kona GPIO\n"); bcm_kona_gpio_reset(kona_gpio);
The physical address of the GPIO memory address is already printed implicitly by dev_info() as part of the device name. The virtual address doesn't add any value. In addition, printing a resource_size_t with %x lead to a compiler warning on some platforms. Signed-off-by: Markus Mayer <markus.mayer@linaro.org> --- This patch is dependent on: - http://patches.linaro.org/19933/ drivers/gpio/gpio-bcm-kona.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)