| Message ID | 20200509151519.GA7100@localhost.localdomain |
|---|---|
| State | New |
| Headers | show |
| Series | lib: linear_ranges: Add missing MODULE_LICENSE() | expand |
diff --git a/lib/linear_ranges.c b/lib/linear_ranges.c index d1336c75ccd7..9495ef3572b7 100644 --- a/lib/linear_ranges.c +++ b/lib/linear_ranges.c @@ -12,6 +12,7 @@ #include <linux/export.h> #include <linux/kernel.h> #include <linux/linear_range.h> +#include <linux/module.h> /** * linear_range_values_in_range - return the amount of values in a range @@ -239,3 +240,6 @@ int linear_range_get_selector_high(const struct linear_range *r, return 0; } EXPORT_SYMBOL_GPL(linear_range_get_selector_high); + +MODULE_DESCRIPTION("linear-ranges helper"); +MODULE_LICENSE("GPL");
When linear_ranges is compiled as module we get warning about missing MODULE_LICENSE(). Fix it by adding MODULE_LICENSE("GPL") as is suggested by SPDX and EXPORTs. Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- I saw Mark applied the linear-ranges patch. So I sent this fix as incremental patch - but I still use the same Linus tree as a base of this fix - the linear-ranges file should be unchanged in regulator tree. If this does not apply I can clone regulator tree and create this fix on it. I don't know if this is the correct way to fix this as the linear-ranges should be merged to power-supply tree. I guess we can either: - Use this patch to fix regulator tree and create fixed tag for power-supply(?) - Add this fix in the original series and resend whole series(?) - re-create the series and drop the already applied patches. Add this fix as a fixup patch in new series and apply it to power-supply tree after the linear-ranges from regulator is merged to power-supply. Please adviece me if this patch is not the way to go. Oh, and I am really sorry for the trouble. I saw I had regulators=y in all of my compilations due to some pincontrol dependencies. So linear-ranges was not built as module in any of my test compilations :( Thanks for testing Mark! lib/linear_ranges.c | 4 ++++ 1 file changed, 4 insertions(+)