diff mbox series

[RTEVAL,3/3] modules: Don't abort if a workload isn't running

Message ID 20200406221405.3043-3-swood@redhat.com
State New
Headers show
Series None | expand

Commit Message

Crystal Wood April 6, 2020, 10:14 p.m. UTC
Each module is responsible for respawning the load when it finishes.  The
only thing that the additional check at the rtevalModulePrototype level
accomplishes is introducing a race condition that will kill rteval if a
load ends after _WorkloadTask() checks, but before the check in the
caller.

Signed-off-by: Scott Wood <swood@redhat.com>
---
 rteval/modules/__init__.py | 3 ---
 1 file changed, 3 deletions(-)
diff mbox series

Patch

diff --git a/rteval/modules/__init__.py b/rteval/modules/__init__.py
index 0feb8a916179..5ae7cd488406 100644
--- a/rteval/modules/__init__.py
+++ b/rteval/modules/__init__.py
@@ -189,9 +189,6 @@  class rtevalModulePrototype(threading.Thread):
 
                 if self.shouldStop():
                     break
-                if not self.WorkloadAlive():
-                    self._log(Log.DEBUG, "%s workload stopped running." % self._module_type)
-                    break
                 time.sleep(self.__sleeptime)
 
             self.__timestamps["runloop_stop"] = datetime.now()