| Message ID | BN6PR04MB066006C199A43996C0502B62A3AE0@BN6PR04MB0660.namprd04.prod.outlook.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
On Sat, Apr 25, 2020 at 07:26:41PM -0700, Jonathan Bakker wrote: > From: Tomasz Figa <tomasz.figa@gmail.com> > > On FIMC variants which don't have writeback channel, there is no need to > access system registers. This patch makes the driver request sysreg > regmap conditionally depending on whether writeback is supported. > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> > --- > drivers/media/platform/exynos4-is/fimc-core.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > Reviewed-by: Tomasz Figa <tfiga@chromium.org> Best regards, Tomasz
On 26.04.2020 04:26, Jonathan Bakker wrote: > From: Tomasz Figa <tomasz.figa@gmail.com> > > On FIMC variants which don't have writeback channel, there is no need to > access system registers. This patch makes the driver request sysreg > regmap conditionally depending on whether writeback is supported. > > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com> > Signed-off-by: Jonathan Bakker <xc-racer2@live.ca> Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers/media/platform/exynos4-is/fimc-core.c index 2258f3bfc929..08d1f39a914c 100644 --- a/drivers/media/platform/exynos4-is/fimc-core.c +++ b/drivers/media/platform/exynos4-is/fimc-core.c @@ -954,9 +954,11 @@ static int fimc_probe(struct platform_device *pdev) spin_lock_init(&fimc->slock); mutex_init(&fimc->lock); - fimc->sysreg = fimc_get_sysreg_regmap(dev->of_node); - if (IS_ERR(fimc->sysreg)) - return PTR_ERR(fimc->sysreg); + if (fimc->variant->has_isp_wb) { + fimc->sysreg = fimc_get_sysreg_regmap(dev->of_node); + if (IS_ERR(fimc->sysreg)) + return PTR_ERR(fimc->sysreg); + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); fimc->regs = devm_ioremap_resource(dev, res);