| Message ID | 20200605110258.GD978434@mwanda |
|---|---|
| State | New |
| Headers | show |
| Series | cxlflash: remove an unnecessary NULL check | expand |
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c index fcc5aa9f60147..94250ebe9e803 100644 --- a/drivers/scsi/cxlflash/main.c +++ b/drivers/scsi/cxlflash/main.c @@ -47,9 +47,6 @@ static void process_cmd_err(struct afu_cmd *cmd, struct scsi_cmnd *scp) struct sisl_ioasa *ioasa; u32 resid; - if (unlikely(!cmd)) - return; - ioasa = &(cmd->sa); if (ioasa->rc.flags & SISL_RC_FLAGS_UNDERRUN) {
The "cmd" pointer was already dereferenced a couple lines earlier so this NULL check is too late. Fortunately, the pointer can never be NULL and the check can be removed. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/scsi/cxlflash/main.c | 3 --- 1 file changed, 3 deletions(-)