| Message ID | 20200310100219.5421-1-yangerkun@huawei.com |
|---|---|
| State | New |
| Headers | show |
| Series | [4.4.y/4.9.y] NFS: fix highmem leak exist in nfs_readdir_xdr_to_array | expand |
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index c2665d920cf8..2517fcd423b6 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -678,8 +678,6 @@ int nfs_readdir_xdr_to_array(nfs_readdir_descriptor_t *desc, struct page *page, goto out_label_free; } - array = kmap(page); - status = nfs_readdir_alloc_pages(pages, array_size); if (status < 0) goto out_release_array;
The patch 'e22dea67d2f7 ("NFS: Fix memory leaks and corruption in readdir")' in 4.4.y/4.9.y will introduce a highmem leak. Actually, nfs_readdir_get_array has did what we want to do. No need to call kmap again. Signed-off-by: yangerkun <yangerkun@huawei.com> --- fs/nfs/dir.c | 2 -- 1 file changed, 2 deletions(-)