| Message ID | 1389960374-16694-2-git-send-email-koen.kooi@linaro.org |
|---|---|
| State | Accepted |
| Commit | ef03b5a1180e89afae8ab80ec826c27905d88e52 |
| Headers | show |
On 01/22/2014 03:13 PM, Otavio Salvador wrote: > On Fri, Jan 17, 2014 at 10:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote: >> No need to patch the makefile when you can just passs CC=${TARGET_PREFIX}gcc to make. >> >> Signed-off-by: Koen Kooi <koen.kooi@linaro.org> > > You have a typo in the commit log: "pass" > > What about the HOST variable from the Makefile which were removed and > now set to _CYGWIN? I didn't touch HOST, the patch only touched CC and now the patch isn't applied anymore. So either way, no changes to HOST.
Tested-by: Fathi Boudra <fathi.boudra@linaro.org> On 22 January 2014 16:29, Koen Kooi <koen.kooi@linaro.org> wrote: > On 01/22/2014 03:13 PM, Otavio Salvador wrote: >> >> On Fri, Jan 17, 2014 at 10:06 AM, Koen Kooi <koen.kooi@linaro.org> wrote: >>> >>> No need to patch the makefile when you can just passs >>> CC=${TARGET_PREFIX}gcc to make. >>> >>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org> >> >> >> You have a typo in the commit log: "pass" >> >> What about the HOST variable from the Makefile which were removed and >> now set to _CYGWIN? > > > I didn't touch HOST, the patch only touched CC and now the patch isn't > applied anymore. So either way, no changes to HOST. > > -- > Koen Kooi > Builds and Baselines | Release Manager > Linaro.org | Open source software for ARM SoCs > > _______________________________________________ > Openembedded-devel mailing list > Openembedded-devel@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff --git a/meta-oe/recipes-extended/acpica/acpica_20140114.bb b/meta-oe/recipes-extended/acpica/acpica_20140114.bb index 5cc2d5a..2bb7ad7 100644 --- a/meta-oe/recipes-extended/acpica/acpica_20140114.bb +++ b/meta-oe/recipes-extended/acpica/acpica_20140114.bb @@ -12,7 +12,6 @@ LIC_FILES_CHKSUM = "file://generate/unix/readme.txt;md5=204407e197c1a01154a48f6c DEPENDS = "bison flex" SRC_URI = "https://acpica.org/sites/acpica/files/acpica-unix2-${PV}.tar.gz \ - file://cross-compile.patch \ file://no-werror.patch \ " SRC_URI[md5sum] = "fcd4b7304f1bfabc7d4b9cfdecc6b0c6" @@ -20,7 +19,7 @@ SRC_URI[sha256sum] = "0d5bd32690ab77e21ab143ef25361c314a4ed13c33a5fb3ddd6f5559ab S = "${WORKDIR}/acpica-unix2-${PV}" -EXTRA_OEMAKE = "'OPT_CFLAGS=-Wall'" +EXTRA_OEMAKE = "CC=${TARGET_PREFIX}gcc 'OPT_CFLAGS=-Wall'" do_install() { install -D -p -m0755 generate/unix/bin*/iasl ${D}${bindir}/iasl diff --git a/meta-oe/recipes-extended/acpica/files/cross-compile.patch b/meta-oe/recipes-extended/acpica/files/cross-compile.patch deleted file mode 100644 index f2917ca..0000000 --- a/meta-oe/recipes-extended/acpica/files/cross-compile.patch +++ /dev/null @@ -1,19 +0,0 @@ -Description: add cross compile support -Forwarded: not-needed -Author: Fathi Boudra <fathi.boudra@linaro.org> - ---- - generate/unix/Makefile.config | 2 +- - 1 file changed, 1 insertion(+), 1 deletion(-) - ---- a/generate/unix/Makefile.config -+++ b/generate/unix/Makefile.config -@@ -35,7 +35,7 @@ - .SUFFIXES : - PROGS = acpibin acpidump acpiexec acpihelp acpinames acpisrc acpixtract iasl - HOST ?= _CYGWIN --CC = gcc -+CC ?= $(CROSS_COMPILE)gcc - - # - # Common defines
No need to patch the makefile when you can just passs CC=${TARGET_PREFIX}gcc to make. Signed-off-by: Koen Kooi <koen.kooi@linaro.org> --- meta-oe/recipes-extended/acpica/acpica_20140114.bb | 3 +-- .../recipes-extended/acpica/files/cross-compile.patch | 19 ------------------- 2 files changed, 1 insertion(+), 21 deletions(-) delete mode 100644 meta-oe/recipes-extended/acpica/files/cross-compile.patch