From patchwork Mon Jul 6 13:33:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 234880 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp4781674ilg; Mon, 6 Jul 2020 06:36:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdBi25EMMbr7ti1zxj338Zxv/BeaAIDjzo7VQ6i6iKXq4Q7ubsdQX5qbqvWTO56wlwLdcM X-Received: by 2002:aa7:ce91:: with SMTP id y17mr34482758edv.105.1594042597522; Mon, 06 Jul 2020 06:36:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1594042597; cv=none; d=google.com; s=arc-20160816; b=qTO/SHxVMm5+RWQpKaU+5gEIFdLbUmyA98Zkrv8NnQx7hztbMiT6uWCmTsgF5LsCYh d1Fno2oHOWUNN5uFgBceHezDRFKL6aJKvyd1NOrUEANNyIbHNp2ZrrnLC4uZM16ltmNm PGpq0+GWHWEmd8kOA9I+EMGPwIkdkAft/p9sf94Dwa8iHu99TNafIvTLYS2LW4+JBskL xEeVEskRT6Ol4J9Jqtb+hkoQNh2FLxHa2wVt3J3g5odgt1onvIvuOEs3gW65ILTt9H+9 oOCxrZLFbTKK0mkYzThlxm1mS8T2nFk+ezYcsG8bDlV9nofDqgBBpuQglE92PH5zKVjY fdKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=BLCblSKtPydC5qrse5Ki2yU2neE16Az1VUmVedaucARhgm24aSzYUIF9HK37APuSXH 6ZBRJ9QlmPsnprkYRlS9TXmxC2J84HBDvxQgMoK+qPGhd0oK7l3iSaQR8tfCY8AhNED0 0VfIhXM7ya0DqpVyxdpNIvbEC+zqkrlI+QCxij/OzMbtZn/i4NJ6LzdNGmkHF7JjXvc0 loPLCdsFSByqpkQdRyTsnSrtq2EadCfzhQ4bMnEkSyy5JxAai3DSAr7Upzo231jNGSUV 3BL1n+Hm6Ej+Rr4kpHevSAnlb1sRYVzyA/DaWIgsBYEmIJdz024xnf91AAEUymtrp7gO SxjQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tb+/K0K1"; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu27si12871462edb.542.2020.07.06.06.36.37; Mon, 06 Jul 2020 06:36:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="tb+/K0K1"; spf=pass (google.com: domain of linux-usb-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-usb-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729215AbgGFNds (ORCPT + 5 others); Mon, 6 Jul 2020 09:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47124 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729209AbgGFNdr (ORCPT ); Mon, 6 Jul 2020 09:33:47 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5ED1C061794 for ; Mon, 6 Jul 2020 06:33:46 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id o2so42117292wmh.2 for ; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=tb+/K0K1eA704mpMyghl55v/zWI4mSEucjEWMkto05EJAwtt81Tuc5Ialuiq8LeS2R x7eNhrR5yGpofVpGMlUc+dGvW6hOfzZAKfuPvTYOL9cr6csy+Q7aT4rJAe+QBVgDpCWB JmX38nI6hJKRDaLdaCbKahq0CK0atprPWa2Wn5hZzUEnnjAXQrcx+95LGiam9CAdWbmM QFxzd5VOEiDqMgyMUKWN0JEn5Yco8m9QTRctmmUjIDZ2rJKKvS/HJF17k9YJnzu5eULF XF3nsJOJPonHF1SaySMBGld80Ol8vOnadKhByaY0CkSeG7cHOObHZPhTkBpFLNt2aOaX OXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=C1URJ3soQ1gquaTJ38uKPOt2qcuNwkBHiWCoNex791vP8ZlCi9kILAkg6VruIhfrt4 UFv3ekpsw70qeJNGMwRy79twsZoIE0BlPCgQzqYueHU/cHnOdkyE+KZowOCGRjfQYglR +2XYq0mfNh4rzWWhp7eaC5ibQBZJEHanKgU2h9iRw5E6NnluQWjbsqeZlo6p0PwhBmo6 rdtYwE6XUBBNFDVftz5uequPksl9C5xasvvImPZRYh7yhUWI6TOOPTohzzNTNNjjxCAj JzjiWzsb59wlZis6S4gtNjfKJw2ZRmbW/vwJv/UmbjfzlfwtWwzxxYBf6Mg8TAwbijzm ekmA== X-Gm-Message-State: AOAM531ibqmx9BIwTsKEwwsYTjZ2ayUdlANgXPwJkXkJvWLI5DPzCpKP r1MK5xYGC4DY0lQW75RBQy1kQl3MB54= X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51110615wma.4.1594042425621; Mon, 06 Jul 2020 06:33:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones , Juergen Stuber , David Glance , david , legousb-devel@lists.sourceforge.net Subject: [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:10 +0100 Message-Id: <20200706133341.476881-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release' drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write' drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback' drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) -- 2.25.1 diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index ab4b98b041158..8aca55c4c95f1 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -283,7 +283,7 @@ static inline void lego_usb_tower_debug_data(struct device *dev, } -/** +/* * tower_delete */ static inline void tower_delete(struct lego_usb_tower *dev) @@ -299,7 +299,7 @@ static inline void tower_delete(struct lego_usb_tower *dev) } -/** +/* * tower_open */ static int tower_open(struct inode *inode, struct file *file) @@ -398,7 +398,7 @@ static int tower_open(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_release */ static int tower_release(struct inode *inode, struct file *file) @@ -440,7 +440,7 @@ static int tower_release(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_check_for_read_packet * * To get correct semantics for signals and non-blocking I/O @@ -461,7 +461,7 @@ static void tower_check_for_read_packet(struct lego_usb_tower *dev) } -/** +/* * tower_poll */ static __poll_t tower_poll(struct file *file, poll_table *wait) @@ -487,7 +487,7 @@ static __poll_t tower_poll(struct file *file, poll_table *wait) } -/** +/* * tower_llseek */ static loff_t tower_llseek(struct file *file, loff_t off, int whence) @@ -496,7 +496,7 @@ static loff_t tower_llseek(struct file *file, loff_t off, int whence) } -/** +/* * tower_read */ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) @@ -580,7 +580,7 @@ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, } -/** +/* * tower_write */ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t count, loff_t *ppos) @@ -662,7 +662,7 @@ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t } -/** +/* * tower_interrupt_in_callback */ static void tower_interrupt_in_callback(struct urb *urb) @@ -717,7 +717,7 @@ static void tower_interrupt_in_callback(struct urb *urb) } -/** +/* * tower_interrupt_out_callback */ static void tower_interrupt_out_callback(struct urb *urb) @@ -742,7 +742,7 @@ static void tower_interrupt_out_callback(struct urb *urb) } -/** +/* * tower_probe * * Called by the usb core when a new device is connected that it thinks @@ -854,7 +854,7 @@ static int tower_probe(struct usb_interface *interface, const struct usb_device_ } -/** +/* * tower_disconnect * * Called by the usb core when the device is removed from the system.