diff mbox series

[u-boot-marvell,1/1] clk: armada-37xx-periph: fix DDR PHY clock divider values

Message ID 20200414225918.12844-1-marek.behun@nic.cz
State Accepted
Commit 239f424f497dcda32322d3ee990f20d26a5a2f47
Headers show
Series [u-boot-marvell,1/1] clk: armada-37xx-periph: fix DDR PHY clock divider values | expand

Commit Message

Marek BehĂșn April 14, 2020, 10:59 p.m. UTC
Register value table for DDR PHY clock divider are wrong. They should be
0 or 1 for divide-by-2 or divide-by-4, respectively. Not 1 or 2. Current
values do not make sense, since 2 cannot be achieved, because the
register is only 1 bit long (mask is set to 1).

This fixes clk dump reporting DDR PHY clock rate differently from Linux.

Signed-off-by: Marek Beh?n <marek.behun at nic.cz>
---
 drivers/clk/mvebu/armada-37xx-periph.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Stefan Roese April 15, 2020, 6:37 a.m. UTC | #1
On 15.04.20 00:59, Marek Beh?n wrote:
> Register value table for DDR PHY clock divider are wrong. They should be
> 0 or 1 for divide-by-2 or divide-by-4, respectively. Not 1 or 2. Current
> values do not make sense, since 2 cannot be achieved, because the
> register is only 1 bit long (mask is set to 1).
> 
> This fixes clk dump reporting DDR PHY clock rate differently from Linux.
> 
> Signed-off-by: Marek Beh?n <marek.behun at nic.cz>

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan

> ---
>   drivers/clk/mvebu/armada-37xx-periph.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
> index 068e48ea04..855f979b4f 100644
> --- a/drivers/clk/mvebu/armada-37xx-periph.c
> +++ b/drivers/clk/mvebu/armada-37xx-periph.c
> @@ -89,8 +89,8 @@ static const struct clk_div_table div_table1[] = {
>   };
>   
>   static const struct clk_div_table div_table2[] = {
> -	{ 2, 1 },
> -	{ 4, 2 },
> +	{ 2, 0 },
> +	{ 4, 1 },
>   	{ 0, 0 },
>   };
>   
> 


Viele Gr??e,
Stefan
diff mbox series

Patch

diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c
index 068e48ea04..855f979b4f 100644
--- a/drivers/clk/mvebu/armada-37xx-periph.c
+++ b/drivers/clk/mvebu/armada-37xx-periph.c
@@ -89,8 +89,8 @@  static const struct clk_div_table div_table1[] = {
 };
 
 static const struct clk_div_table div_table2[] = {
-	{ 2, 1 },
-	{ 4, 2 },
+	{ 2, 0 },
+	{ 4, 1 },
 	{ 0, 0 },
 };