| Message ID | 20200415164623.142908-5-xypron.glpk@gmx.de |
|---|---|
| State | Accepted |
| Commit | f6a24a177f3e09d9c954b25f5a52cdfdea3e6c85 |
| Headers | show |
| Series | lib: reduce SPL size | expand |
On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote: > SPL should not be enlarged by building with CONFIG_HEXDUMP=y. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > --- > lib/hexdump.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Does this show up as a problem somewhere? I don't see this resulting in size savings anywhere, thanks.
On 4/16/20 4:32 AM, Tom Rini wrote: > On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote: > >> SPL should not be enlarged by building with CONFIG_HEXDUMP=y. >> >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> >> --- >> lib/hexdump.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Does this show up as a problem somewhere? I don't see this resulting in > size savings anywhere, thanks. > I checked for origin/master pine64_defconfig with HEXDUMP 1493728 spl/u-boot-spl without HEXDUMP 1485712 spl/u-boot-spl Currently no driver is actually calling the hexdump function is SPL. So the code seems to be removed in the final binary. Best regards Heinrich
On Thu, Apr 16, 2020 at 06:27:00PM +0200, Heinrich Schuchardt wrote: > On 4/16/20 4:32 AM, Tom Rini wrote: > > On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote: > > > >> SPL should not be enlarged by building with CONFIG_HEXDUMP=y. > >> > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > >> --- > >> lib/hexdump.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Does this show up as a problem somewhere? I don't see this resulting in > > size savings anywhere, thanks. > > > > I checked for origin/master pine64_defconfig > > with HEXDUMP > 1493728 spl/u-boot-spl > > without HEXDUMP > 1485712 spl/u-boot-spl > > Currently no driver is actually calling the hexdump function is SPL. So > the code seems to be removed in the final binary. OK, thanks. Reviewed-by: Tom Rini <trini at konsulko.com>
On Wed, Apr 15, 2020 at 06:46:22PM +0200, Heinrich Schuchardt wrote: > SPL should not be enlarged by building with CONFIG_HEXDUMP=y. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> > Reviewed-by: Tom Rini <trini at konsulko.com> Applied to u-boot/master, thanks!
diff --git a/lib/hexdump.c b/lib/hexdump.c index bf14b5bdbd..a3f219a874 100644 --- a/lib/hexdump.c +++ b/lib/hexdump.c @@ -18,7 +18,7 @@ const char hex_asc[] = "0123456789abcdef"; const char hex_asc_upper[] = "0123456789ABCDEF"; -#ifdef CONFIG_HEXDUMP +#if CONFIG_IS_ENABLED(HEXDUMP) /** * hex_dump_to_buffer - convert a blob of data to "hex ASCII" in memory * @buf: data blob to dump
SPL should not be enlarged by building with CONFIG_HEXDUMP=y. Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de> --- lib/hexdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.25.1