| Message ID | 20200420201521.965063-1-pbrobinson@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | configs: rockpro64-rk3399: Enable the bits for SPI flash | expand |
Hi Peter, On Tue, Apr 21, 2020 at 1:45 AM Peter Robinson <pbrobinson at gmail.com> wrote: > > Enable all the config options needed for SPI flash support > and putting U-Boot on the SPI flash. > > Signed-off-by: Peter Robinson <pbrobinson at gmail.com> > --- > configs/rockpro64-rk3399_defconfig | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > index 8074e4665a..4e7ea8cb6e 100644 > --- a/configs/rockpro64-rk3399_defconfig > +++ b/configs/rockpro64-rk3399_defconfig > @@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1 > CONFIG_DEBUG_UART_BASE=0xFF1A0000 > CONFIG_DEBUG_UART_CLOCK=24000000 > CONFIG_DEBUG_UART=y > +CONFIG_SPL_SPI_SUPPORT=y > +CONFIG_SPL_SPI_FLASH_SUPPORT=y > +CONFIG_SPL_MTD_SUPPORT=y Does Boot from SPI work for this via TPL? > CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb" > CONFIG_MISC_INIT_R=y > CONFIG_DISPLAY_BOARDINFO_LATE=y > @@ -18,6 +21,8 @@ CONFIG_TPL=y > CONFIG_CMD_BOOTZ=y > CONFIG_CMD_GPT=y > CONFIG_CMD_MMC=y > +CONFIG_CMD_MTDPARTS=y > +CONFIG_CMD_SF=y This won't need, will select if we have DM SPI and FLASH. > CONFIG_CMD_USB=y > # CONFIG_CMD_SETEXPR is not set > CONFIG_CMD_TIME=y > @@ -34,7 +39,11 @@ CONFIG_MMC_DW=y > CONFIG_MMC_DW_ROCKCHIP=y > CONFIG_MMC_SDHCI=y > CONFIG_MMC_SDHCI_ROCKCHIP=y > +CONFIG_ROCKCHIP_SPI=y > +CONFIG_SF_DEFAULT_SPEED=20000000 > +CONFIG_SPI_FLASH=y > CONFIG_SPI_FLASH_GIGADEVICE=y > +CONFIG_SPI_FLASH_WINBOND=y Well, CONFIG_SPI_FLASH_WINBOND=y CONFIG_ROCKCHIP_SPI=y Enough to enable SPI Flash on rk3399 platforms. refer this sha1 3d11196c802da6bb91562c9a105e401aa68b6629 Jagan.
Hi Peter, ??? Does Jagan's suggestion available for you? Thanks, - Kever On 2020/4/25 ??8:34, Jagan Teki wrote: > Hi Peter, > > On Tue, Apr 21, 2020 at 1:45 AM Peter Robinson <pbrobinson at gmail.com> wrote: >> Enable all the config options needed for SPI flash support >> and putting U-Boot on the SPI flash. >> >> Signed-off-by: Peter Robinson <pbrobinson at gmail.com> >> --- >> configs/rockpro64-rk3399_defconfig | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig >> index 8074e4665a..4e7ea8cb6e 100644 >> --- a/configs/rockpro64-rk3399_defconfig >> +++ b/configs/rockpro64-rk3399_defconfig >> @@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1 >> CONFIG_DEBUG_UART_BASE=0xFF1A0000 >> CONFIG_DEBUG_UART_CLOCK=24000000 >> CONFIG_DEBUG_UART=y >> +CONFIG_SPL_SPI_SUPPORT=y >> +CONFIG_SPL_SPI_FLASH_SUPPORT=y >> +CONFIG_SPL_MTD_SUPPORT=y > Does Boot from SPI work for this via TPL? > >> CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb" >> CONFIG_MISC_INIT_R=y >> CONFIG_DISPLAY_BOARDINFO_LATE=y >> @@ -18,6 +21,8 @@ CONFIG_TPL=y >> CONFIG_CMD_BOOTZ=y >> CONFIG_CMD_GPT=y >> CONFIG_CMD_MMC=y >> +CONFIG_CMD_MTDPARTS=y >> +CONFIG_CMD_SF=y > This won't need, will select if we have DM SPI and FLASH. > >> CONFIG_CMD_USB=y >> # CONFIG_CMD_SETEXPR is not set >> CONFIG_CMD_TIME=y >> @@ -34,7 +39,11 @@ CONFIG_MMC_DW=y >> CONFIG_MMC_DW_ROCKCHIP=y >> CONFIG_MMC_SDHCI=y >> CONFIG_MMC_SDHCI_ROCKCHIP=y >> +CONFIG_ROCKCHIP_SPI=y >> +CONFIG_SF_DEFAULT_SPEED=20000000 >> +CONFIG_SPI_FLASH=y >> CONFIG_SPI_FLASH_GIGADEVICE=y >> +CONFIG_SPI_FLASH_WINBOND=y > Well, > CONFIG_SPI_FLASH_WINBOND=y > CONFIG_ROCKCHIP_SPI=y > > Enough to enable SPI Flash on rk3399 platforms. refer this sha1 > 3d11196c802da6bb91562c9a105e401aa68b6629 > > Jagan. > >
On Tue, Apr 28, 2020 at 2:44 PM Kever Yang <kever.yang at rock-chips.com> wrote: > > Hi Peter, > > Does Jagan's suggestion available for you? I've not had time to test it hence the reason I've not replied but in the very lead Pine64 documents, see on pretty much all their board pages, that they may have either Winbond or Gigadevice SPI flash parts [1] so his suggestion is incomplete. Peter [1] https://wiki.pine64.org/index.php/ROCKPro64#Datasheets_for_Components_and_Peripherals > On 2020/4/25 ??8:34, Jagan Teki wrote: > > Hi Peter, > > > > On Tue, Apr 21, 2020 at 1:45 AM Peter Robinson <pbrobinson at gmail.com> wrote: > >> Enable all the config options needed for SPI flash support > >> and putting U-Boot on the SPI flash. > >> > >> Signed-off-by: Peter Robinson <pbrobinson at gmail.com> > >> --- > >> configs/rockpro64-rk3399_defconfig | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig > >> index 8074e4665a..4e7ea8cb6e 100644 > >> --- a/configs/rockpro64-rk3399_defconfig > >> +++ b/configs/rockpro64-rk3399_defconfig > >> @@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1 > >> CONFIG_DEBUG_UART_BASE=0xFF1A0000 > >> CONFIG_DEBUG_UART_CLOCK=24000000 > >> CONFIG_DEBUG_UART=y > >> +CONFIG_SPL_SPI_SUPPORT=y > >> +CONFIG_SPL_SPI_FLASH_SUPPORT=y > >> +CONFIG_SPL_MTD_SUPPORT=y > > Does Boot from SPI work for this via TPL? > > > >> CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb" > >> CONFIG_MISC_INIT_R=y > >> CONFIG_DISPLAY_BOARDINFO_LATE=y > >> @@ -18,6 +21,8 @@ CONFIG_TPL=y > >> CONFIG_CMD_BOOTZ=y > >> CONFIG_CMD_GPT=y > >> CONFIG_CMD_MMC=y > >> +CONFIG_CMD_MTDPARTS=y > >> +CONFIG_CMD_SF=y > > This won't need, will select if we have DM SPI and FLASH. > > > >> CONFIG_CMD_USB=y > >> # CONFIG_CMD_SETEXPR is not set > >> CONFIG_CMD_TIME=y > >> @@ -34,7 +39,11 @@ CONFIG_MMC_DW=y > >> CONFIG_MMC_DW_ROCKCHIP=y > >> CONFIG_MMC_SDHCI=y > >> CONFIG_MMC_SDHCI_ROCKCHIP=y > >> +CONFIG_ROCKCHIP_SPI=y > >> +CONFIG_SF_DEFAULT_SPEED=20000000 > >> +CONFIG_SPI_FLASH=y > >> CONFIG_SPI_FLASH_GIGADEVICE=y > >> +CONFIG_SPI_FLASH_WINBOND=y > > Well, > > CONFIG_SPI_FLASH_WINBOND=y > > CONFIG_ROCKCHIP_SPI=y > > > > Enough to enable SPI Flash on rk3399 platforms. refer this sha1 > > 3d11196c802da6bb91562c9a105e401aa68b6629 > > > > Jagan. > > > > > >
diff --git a/configs/rockpro64-rk3399_defconfig b/configs/rockpro64-rk3399_defconfig index 8074e4665a..4e7ea8cb6e 100644 --- a/configs/rockpro64-rk3399_defconfig +++ b/configs/rockpro64-rk3399_defconfig @@ -8,6 +8,9 @@ CONFIG_NR_DRAM_BANKS=1 CONFIG_DEBUG_UART_BASE=0xFF1A0000 CONFIG_DEBUG_UART_CLOCK=24000000 CONFIG_DEBUG_UART=y +CONFIG_SPL_SPI_SUPPORT=y +CONFIG_SPL_SPI_FLASH_SUPPORT=y +CONFIG_SPL_MTD_SUPPORT=y CONFIG_DEFAULT_FDT_FILE="rockchip/rk3399-rockpro64.dtb" CONFIG_MISC_INIT_R=y CONFIG_DISPLAY_BOARDINFO_LATE=y @@ -18,6 +21,8 @@ CONFIG_TPL=y CONFIG_CMD_BOOTZ=y CONFIG_CMD_GPT=y CONFIG_CMD_MMC=y +CONFIG_CMD_MTDPARTS=y +CONFIG_CMD_SF=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set CONFIG_CMD_TIME=y @@ -34,7 +39,11 @@ CONFIG_MMC_DW=y CONFIG_MMC_DW_ROCKCHIP=y CONFIG_MMC_SDHCI=y CONFIG_MMC_SDHCI_ROCKCHIP=y +CONFIG_ROCKCHIP_SPI=y +CONFIG_SF_DEFAULT_SPEED=20000000 +CONFIG_SPI_FLASH=y CONFIG_SPI_FLASH_GIGADEVICE=y +CONFIG_SPI_FLASH_WINBOND=y CONFIG_DM_ETH=y CONFIG_ETH_DESIGNWARE=y CONFIG_GMAC_ROCKCHIP=y
Enable all the config options needed for SPI flash support and putting U-Boot on the SPI flash. Signed-off-by: Peter Robinson <pbrobinson at gmail.com> --- configs/rockpro64-rk3399_defconfig | 9 +++++++++ 1 file changed, 9 insertions(+)