diff mbox series

imx8: Run SPL with caches enabled

Message ID 20200421150245.30130-1-festevam@gmail.com
State Accepted
Commit 7e30a3eb768a2893c0bfc7a6fd5046b269df713d
Headers show
Series imx8: Run SPL with caches enabled | expand

Commit Message

Fabio Estevam April 21, 2020, 3:02 p.m. UTC
It is safe to run SPL with caches enabled on i.MX8, so
remove such restriction.

Signed-off-by: Fabio Estevam <festevam at gmail.com>
---
 configs/deneb_defconfig                | 2 --
 configs/giedi_defconfig                | 2 --
 configs/imx8mm_evk_defconfig           | 2 --
 configs/imx8mn_ddr4_evk_defconfig      | 2 --
 configs/imx8mp_evk_defconfig           | 2 --
 configs/imx8mq_evk_defconfig           | 2 --
 configs/imx8qm_mek_defconfig           | 2 --
 configs/imx8qm_rom7720_a1_4G_defconfig | 2 --
 configs/verdin-imx8mm_defconfig        | 2 --
 9 files changed, 18 deletions(-)

Comments

Peng Fan April 22, 2020, 1:16 a.m. UTC | #1
> Subject: [PATCH] imx8: Run SPL with caches enabled
> 
> It is safe to run SPL with caches enabled on i.MX8, so remove such restriction.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Acked-by: Peng Fan <peng.fan at nxp.com>
Oliver Graute April 22, 2020, 1:48 p.m. UTC | #2
On 21/04/20, Fabio Estevam wrote:
> It is safe to run SPL with caches enabled on i.MX8, so
> remove such restriction.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

Acked-by: Oliver Graute <oliver.graute at kococonnector.com>
Anatolij Gustschin April 26, 2020, 8:36 p.m. UTC | #3
Hi Fabio,

On Tue, 21 Apr 2020 12:02:45 -0300
Fabio Estevam festevam at gmail.com wrote:

> It is safe to run SPL with caches enabled on i.MX8, so
> remove such restriction.
> 
> Signed-off-by: Fabio Estevam <festevam at gmail.com>

for deneb/giedi boards

Acked-by: Anatolij Gustschin <agust at denx.de>

--
Anatolij
Igor Opaniuk April 29, 2020, 3:36 p.m. UTC | #4
Hi Fabio,

On Tue, Apr 21, 2020 at 6:02 PM Fabio Estevam <festevam at gmail.com> wrote:
>
> It is safe to run SPL with caches enabled on i.MX8, so
> remove such restriction.
>
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> ---
>  configs/deneb_defconfig                | 2 --
>  configs/giedi_defconfig                | 2 --
>  configs/imx8mm_evk_defconfig           | 2 --
>  configs/imx8mn_ddr4_evk_defconfig      | 2 --
>  configs/imx8mp_evk_defconfig           | 2 --
>  configs/imx8mq_evk_defconfig           | 2 --
>  configs/imx8qm_mek_defconfig           | 2 --
>  configs/imx8qm_rom7720_a1_4G_defconfig | 2 --
>  configs/verdin-imx8mm_defconfig        | 2 --
>  9 files changed, 18 deletions(-)
>
> diff --git a/configs/deneb_defconfig b/configs/deneb_defconfig
> index 388330afc4..628b3516a8 100644
> --- a/configs/deneb_defconfig
> +++ b/configs/deneb_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8=y
>  CONFIG_SYS_TEXT_BASE=0x80020000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/giedi_defconfig b/configs/giedi_defconfig
> index 957875f782..3cae981a61 100644
> --- a/configs/giedi_defconfig
> +++ b/configs/giedi_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8=y
>  CONFIG_SYS_TEXT_BASE=0x80020000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/imx8mm_evk_defconfig b/configs/imx8mm_evk_defconfig
> index 1403067130..78f3d60018 100644
> --- a/configs/imx8mm_evk_defconfig
> +++ b/configs/imx8mm_evk_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8M=y
>  CONFIG_SYS_TEXT_BASE=0x40200000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/imx8mn_ddr4_evk_defconfig b/configs/imx8mn_ddr4_evk_defconfig
> index e3f99896a6..8cf43eb078 100644
> --- a/configs/imx8mn_ddr4_evk_defconfig
> +++ b/configs/imx8mn_ddr4_evk_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8M=y
>  CONFIG_SYS_TEXT_BASE=0x40200000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig
> index b181543df5..2b7f7a941a 100644
> --- a/configs/imx8mp_evk_defconfig
> +++ b/configs/imx8mp_evk_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8M=y
>  CONFIG_SYS_TEXT_BASE=0x40200000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
> index a936f5b79d..76f4d9206d 100644
> --- a/configs/imx8mq_evk_defconfig
> +++ b/configs/imx8mq_evk_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8M=y
>  CONFIG_SYS_TEXT_BASE=0x40200000
>  CONFIG_ENV_SIZE=0x1000
> diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig
> index f7debfbe7b..428c7c47cd 100644
> --- a/configs/imx8qm_mek_defconfig
> +++ b/configs/imx8qm_mek_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8=y
>  CONFIG_SYS_TEXT_BASE=0x80020000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/imx8qm_rom7720_a1_4G_defconfig b/configs/imx8qm_rom7720_a1_4G_defconfig
> index 301747a56c..35191447ae 100644
> --- a/configs/imx8qm_rom7720_a1_4G_defconfig
> +++ b/configs/imx8qm_rom7720_a1_4G_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8=y
>  CONFIG_SYS_TEXT_BASE=0x80020000
>  CONFIG_SPL_GPIO_SUPPORT=y
> diff --git a/configs/verdin-imx8mm_defconfig b/configs/verdin-imx8mm_defconfig
> index a964e3ccfd..1dcd6180b9 100644
> --- a/configs/verdin-imx8mm_defconfig
> +++ b/configs/verdin-imx8mm_defconfig
> @@ -1,6 +1,4 @@
>  CONFIG_ARM=y
> -CONFIG_SPL_SYS_ICACHE_OFF=y
> -CONFIG_SPL_SYS_DCACHE_OFF=y
>  CONFIG_ARCH_IMX8M=y
>  CONFIG_SYS_TEXT_BASE=0x40200000
>  CONFIG_SPL_GPIO_SUPPORT=y
> --
> 2.17.1
>

For Verdin board:
Tested-by: Igor Opaniuk <igor.opaniuk at toradex.com>
Acked-by: Igor Opaniuk <igor.opaniuk at toradex.com>
Stefano Babic May 1, 2020, 4:32 p.m. UTC | #5
> It is safe to run SPL with caches enabled on i.MX8, so
> remove such restriction.
> Signed-off-by: Fabio Estevam <festevam at gmail.com>
> Acked-by: Peng Fan <peng.fan at nxp.com>
> Acked-by: Oliver Graute <oliver.graute at kococonnector.com>
> Acked-by: Anatolij Gustschin <agust at denx.de>
> Tested-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> Acked-by: Igor Opaniuk <igor.opaniuk at toradex.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic
diff mbox series

Patch

diff --git a/configs/deneb_defconfig b/configs/deneb_defconfig
index 388330afc4..628b3516a8 100644
--- a/configs/deneb_defconfig
+++ b/configs/deneb_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8=y
 CONFIG_SYS_TEXT_BASE=0x80020000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/giedi_defconfig b/configs/giedi_defconfig
index 957875f782..3cae981a61 100644
--- a/configs/giedi_defconfig
+++ b/configs/giedi_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8=y
 CONFIG_SYS_TEXT_BASE=0x80020000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/imx8mm_evk_defconfig b/configs/imx8mm_evk_defconfig
index 1403067130..78f3d60018 100644
--- a/configs/imx8mm_evk_defconfig
+++ b/configs/imx8mm_evk_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/imx8mn_ddr4_evk_defconfig b/configs/imx8mn_ddr4_evk_defconfig
index e3f99896a6..8cf43eb078 100644
--- a/configs/imx8mn_ddr4_evk_defconfig
+++ b/configs/imx8mn_ddr4_evk_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/imx8mp_evk_defconfig b/configs/imx8mp_evk_defconfig
index b181543df5..2b7f7a941a 100644
--- a/configs/imx8mp_evk_defconfig
+++ b/configs/imx8mp_evk_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
index a936f5b79d..76f4d9206d 100644
--- a/configs/imx8mq_evk_defconfig
+++ b/configs/imx8mq_evk_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_ENV_SIZE=0x1000
diff --git a/configs/imx8qm_mek_defconfig b/configs/imx8qm_mek_defconfig
index f7debfbe7b..428c7c47cd 100644
--- a/configs/imx8qm_mek_defconfig
+++ b/configs/imx8qm_mek_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8=y
 CONFIG_SYS_TEXT_BASE=0x80020000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/imx8qm_rom7720_a1_4G_defconfig b/configs/imx8qm_rom7720_a1_4G_defconfig
index 301747a56c..35191447ae 100644
--- a/configs/imx8qm_rom7720_a1_4G_defconfig
+++ b/configs/imx8qm_rom7720_a1_4G_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8=y
 CONFIG_SYS_TEXT_BASE=0x80020000
 CONFIG_SPL_GPIO_SUPPORT=y
diff --git a/configs/verdin-imx8mm_defconfig b/configs/verdin-imx8mm_defconfig
index a964e3ccfd..1dcd6180b9 100644
--- a/configs/verdin-imx8mm_defconfig
+++ b/configs/verdin-imx8mm_defconfig
@@ -1,6 +1,4 @@ 
 CONFIG_ARM=y
-CONFIG_SPL_SYS_ICACHE_OFF=y
-CONFIG_SPL_SYS_DCACHE_OFF=y
 CONFIG_ARCH_IMX8M=y
 CONFIG_SYS_TEXT_BASE=0x40200000
 CONFIG_SPL_GPIO_SUPPORT=y