sunxi: A20-OLinuXino-Lime2: enable PHY config to fix broken ethernet

Message ID 20200424115411.11102-1-agust@denx.de
State New
Headers show
Series
  • sunxi: A20-OLinuXino-Lime2: enable PHY config to fix broken ethernet
Related show

Commit Message

Anatolij Gustschin April 24, 2020, 11:54 a.m.
Realtek PHY is disabled in defconfig and Gigabit Ethernet support
doesn't work. Re-enable PHY options to fix this.

Signed-off-by: Anatolij Gustschin <agust at denx.de>
Reported-by: Dario <dario86 at tutamail.com>
Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB")
Fixes: 8728c97eff5b ("configs: Re-sync")
---
Cc'ing board & sunxi maintainers. I do not have this board,
so please test if this patch helps to fix broken gigabit
ethernet. Thanks!

 configs/A20-OLinuXino-Lime2_defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jagan Teki May 1, 2020, 4:46 p.m. | #1
On Fri, Apr 24, 2020 at 5:24 PM Anatolij Gustschin <agust at denx.de> wrote:
>
> Realtek PHY is disabled in defconfig and Gigabit Ethernet support
> doesn't work. Re-enable PHY options to fix this.
>
> Signed-off-by: Anatolij Gustschin <agust at denx.de>
> Reported-by: Dario <dario86 at tutamail.com>
> Fixes: af2cbfd6b982 ("drivers: net: Provide Kconfig menu for PHYLIB")
> Fixes: 8728c97eff5b ("configs: Re-sync")
> ---

Please rebase on master and send. fyi, I don't have board
accessibility right now to test this.

Jagan.
Anatolij Gustschin May 1, 2020, 4:55 p.m. | #2
On Fri, 1 May 2020 22:16:16 +0530
Jagan Teki jagan at amarulasolutions.com wrote:
...
> Please rebase on master and send. fyi, I don't have board
> accessibility right now to test this.

This patch should be dropped. Tom already fixed this issue,
please see commit 69a229c6d4b4.

--
Anatolij

Patch

diff --git a/configs/A20-OLinuXino-Lime2_defconfig b/configs/A20-OLinuXino-Lime2_defconfig
index 2b082cab59..28b558cbeb 100644
--- a/configs/A20-OLinuXino-Lime2_defconfig
+++ b/configs/A20-OLinuXino-Lime2_defconfig
@@ -18,6 +18,8 @@  CONFIG_DEFAULT_DEVICE_TREE="sun7i-a20-olinuxino-lime2"
 CONFIG_SCSI_AHCI=y
 CONFIG_DFU_RAM=y
 CONFIG_FASTBOOT_CMD_OEM_FORMAT=y
+CONFIG_PHY_REALTEK=y
+CONFIG_RTL8211X_PHY_FORCE_MASTER=y
 CONFIG_ETH_DESIGNWARE=y
 CONFIG_RGMII=y
 CONFIG_MII=y
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h
index 0ef289fd64..f4bbce8443 100644
--- a/include/configs/sunxi-common.h
+++ b/include/configs/sunxi-common.h
@@ -273,8 +273,10 @@  extern int soft_i2c_gpio_scl;
 /* Ethernet support */
 
 #ifdef CONFIG_SUN7I_GMAC
+#ifndef CONFIG_PHY_REALTEK
 #define CONFIG_PHY_REALTEK
 #endif
+#endif
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CONFIG_USB_OHCI_NEW