[v3,7/7] arm: vexpress64: Remove unneeded CONFIG_ check

Message ID 20200427181804.15787-8-andre.przywara@arm.com
State Superseded
Headers show
Series
  • Arm Juno board OF_CONTROL upgrade
Related show

Commit Message

Andre Przywara April 27, 2020, 6:18 p.m.
CONFIG_SEMIHOSTING is selected for the VFP target by the means of
Kconfig already, there is no need to check this in the header file.

Signed-off-by: Andre Przywara <andre.przywara at arm.com>
Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
---
 include/configs/vexpress_aemv8a.h | 6 ------
 1 file changed, 6 deletions(-)

Comments

Simon Glass April 28, 2020, 5:57 p.m. | #1
On Mon, 27 Apr 2020 at 12:19, Andre Przywara <andre.przywara at arm.com> wrote:
>
> CONFIG_SEMIHOSTING is selected for the VFP target by the means of
> Kconfig already, there is no need to check this in the header file.
>
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> ---
>  include/configs/vexpress_aemv8a.h | 6 ------
>  1 file changed, 6 deletions(-)
>
Reviewed-by: Simon Glass <sjg at chromium.org>
Tom Rini May 7, 2020, 1:04 p.m. | #2
On Mon, Apr 27, 2020 at 07:18:04PM +0100, Andre Przywara wrote:

> CONFIG_SEMIHOSTING is selected for the VFP target by the means of
> Kconfig already, there is no need to check this in the header file.
> 
> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
> Reviewed-by: Linus Walleij <linus.walleij at linaro.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

Patch

diff --git a/include/configs/vexpress_aemv8a.h b/include/configs/vexpress_aemv8a.h
index 08ad368dbb..3d63897054 100644
--- a/include/configs/vexpress_aemv8a.h
+++ b/include/configs/vexpress_aemv8a.h
@@ -7,12 +7,6 @@ 
 #ifndef __VEXPRESS_AEMV8A_H
 #define __VEXPRESS_AEMV8A_H
 
-#ifdef CONFIG_TARGET_VEXPRESS64_BASE_FVP
-#ifndef CONFIG_SEMIHOSTING
-#error CONFIG_TARGET_VEXPRESS64_BASE_FVP requires CONFIG_SEMIHOSTING
-#endif
-#endif
-
 #define CONFIG_REMAKE_ELF
 
 /* Link Definitions */